Skip to content

fix gap between dropdown list and the main part of the control #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrphang wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix gap between dropdown list and the main part of the control #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 70 additions & 0 deletions docs/components/ComponentExamples/PageKsSelect.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,75 @@
</div>
</div>

<div class="basic-block">
<div class="form-group">
<div class="label">Customizing displays</div>
<ks-select
name="custom-labeling"
:items="[
{id: 1, display: 'Screen 1', ident: 'Tall-1', resolution: '1080x1920'},
{id: 2, display: 'Screen 2', ident: 'Wide-1', resolution: '1920x1080'}
]"
item-key="id"
label-key="display"
:single-deselect="true"
v-model="custom_labeling"
>
<template v-slot:label="{value}">
<div>
{{ value.display }}
<div class="text-sm">
<div ><span class="muted uppercase">Identifer:</span> {{ value.ident }}</div>
<div ><span class="muted uppercase">Resolution:</span> {{ value.resolution }}</div>
</div>
</div>
</template>
<template v-slot="{item}">
<div>
{{ item.display }}
<div class="text-sm">
<div ><span class="muted uppercase">Resolution:</span> {{ item.resolution }}</div>
</div>
</div>
</template>
</ks-select>
<code-block>
<template v-pre>
&lt;ks-select
name="custom-labeling"
:items="[
{id: 1, display: 'Screen 1', ident: 'Tall-1', resolution: '1080x1920'},
{id: 2, display: 'Screen 2', ident: 'Wide-1', resolution: '1920x1080'}
]"
item-key="id"
label-key="display"
:single-deselect="true"
v-model="custom_labeling"
>
&lt;template v-slot:label="{value}">
&lt;div>
{{ value.display }}
&lt;div class="text-tiny">
&lt;div >&lt;span class="muted uppercase">Identifer:&lt;/span> {{ value.ident }}&lt;/div>
&lt;div >&lt;span class="muted uppercase">Resolution:&lt;/span> {{ value.resolution }}&lt;/div>
&lt;/div>
&lt;/div>
&lt;/template>
&lt;template v-slot="{item}">
&lt;div>
{{ item.display }}
&lt;div class="text-tiny">
&lt;div >&lt;span class="muted uppercase">Resolution:&lt;/span> {{ item.resolution }}&lt;/div>
&lt;/div>
&lt;/div>
&lt;/template>
&lt;/ks-select>

</template>
</code-block>
</div>
</div>

<div class="alert warning">
<strong>Warning v-model usage:</strong>
<p>
Expand Down Expand Up @@ -282,6 +351,7 @@
},
],
long: null,
custom_labeling: null,
};
},

Expand Down
3 changes: 1 addition & 2 deletions src/components/KsSelect.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,6 @@

handleScroll() {
let list_height = parseInt(this.$refs.list.offsetHeight);
let element_height = this.$el.offsetHeight;
if ( list_height == 0 ) {
this.list_style.top = false;
return;
Expand All @@ -298,7 +297,7 @@
adjustment = 2.125;
}

this.list_style.top = `calc(${element_height -1}px ${operator} ${adjustment}rem)`;
this.list_style.top = `calc(${operator} ${adjustment}rem)`;
}
},

Expand Down