Fix PNG decoder: 16-bit channels, grayscale+alpha (colorType 4), and sub-byte formats by Copilot · Pull Request #96 · cross-org/image

Copilot · 2026-02-20T22:15:43Z

Fixes critical bugs in the PNG decoder's unfilterAndConvert method.

PNG Decoder Fixes (`src/formats/png_base.ts`)

16-bit per-channel images (bitDepth=16): Pixel stride was hardcoded (x*4, x*3, x) — only correct for 8-bit. Now uses x * bytesPerPixel as stride and channelSize = bitDepth >> 3 to address each channel's high byte.
colorType 4 (grayscale+alpha): Was unhandled and threw "Unsupported PNG color type: 4". Now decodes gray + alpha into RGBA correctly.
Sub-byte grayscale (bitDepth 1/2/4): scanlineLength was width * 1 = width bytes, but the correct value is ⌈width × bitsPerPixel / 8⌉. Now computes the correct byte count and unpacks pixel values via bit-extraction with proper 0–255 scaling. The condition is explicit: if (bitDepth < 8 && (colorType === 0 || colorType === 3)) to prevent issues if indexed-color support is added later.

Tests Added (`test/formats/png.test.ts`)

Three new decode-only tests covering each fixed case using minimal hand-crafted PNG binaries.

Bun CI Timeouts (not caused by this PR)

Bun CI shows 7 test timeouts (ICO encode, TIFF Deflate) that are pre-existing and affect all branches — confirmed on a completely separate PR. Root cause has not been determined; a simple CompressionStream("deflate") reproduction did not hang.

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…sub-byte formats Co-authored-by: Hexagon <419737+Hexagon@users.noreply.github.com>

Copilot

Pull request overview

This PR fixes critical bugs in the PNG decoder that prevented correct decoding of 16-bit per-channel images, grayscale+alpha (colorType 4) images, and sub-byte grayscale formats (bitDepth 1/2/4).

Changes:

Fixed pixel stride calculation for 16-bit images to use actual channel size instead of hardcoded 8-bit offsets
Added support for PNG colorType 4 (grayscale+alpha) which was previously unsupported
Corrected scanline length calculation and pixel unpacking for sub-byte grayscale formats (bitDepth 1, 2, 4)

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/formats/png_base.ts	Core decoder fix: replaces hardcoded pixel strides with dynamic calculations based on bitDepth and colorType, adds grayscale+alpha handling, and implements proper sub-byte pixel unpacking
test/formats/png.test.ts	Adds three decode-only tests with minimal hand-crafted PNG binaries to verify each of the three bug fixes
CHANGELOG.md	Documents the three decoder fixes in the Unreleased section under Fixed

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/formats/png_base.ts

Co-authored-by: Hexagon <419737+Hexagon@users.noreply.github.com>

Hexagon · 2026-03-21T20:56:29Z

@copilot investigate bun test failures in ci

7 tests failed:
(fail) ICO: encode and decode - small image [5000.17ms]
^ this test timed out after 5000ms.
(fail) ICO: encode - single pixel [5001.00ms]
^ this test timed out after 5000ms.
(fail) ICO: encode and decode - larger image [5000.04ms]
^ this test timed out after 5000ms.
(fail) ICO: encode and decode - 32x32 image [5000.04ms]
^ this test timed out after 5000ms.
(fail) ICO: encode and decode - with transparency [5000.01ms]
^ this test timed out after 5000ms.
(fail) TIFF: encode and decode with Deflate compression [5000.06ms]
^ this test timed out after 5000ms.
(fail) TIFF: Deflate compression roundtrip [5000.03ms]
^ this test timed out after 5000ms.

…with node:zlib fallback Co-authored-by: Hexagon <419737+Hexagon@users.noreply.github.com> Agent-Logs-Url: https://github.com/cross-org/image/sessions/b9d06be4-3ef7-4982-8355-5e85e31c2768

…ompressionStream hang Co-authored-by: Hexagon <419737+Hexagon@users.noreply.github.com> Agent-Logs-Url: https://github.com/cross-org/image/sessions/b9d06be4-3ef7-4982-8355-5e85e31c2768

Copilot · 2026-03-21T21:05:21Z

@copilot investigate bun test failures in ci

7 tests failed:
...

Investigated in e6f28a2. The 7 Bun timeouts are not caused by this PR — they're pre-existing and affect all branches (confirmed the same failures on a completely separate PR run today: 22883807997).

Root cause: Bun's CompressionStream("deflate") / DecompressionStream("deflate") hangs indefinitely when piped through Response streams. This blocks PNG/APNG/ICO deflate and TIFF Deflate compression. The same code works in Deno and Node.js.

Added BUN_BUG_REPORT.md with a minimal repro script and version template ready to file upstream at https://github.com/oven-sh/bun/issues.

Hexagon · 2026-03-21T21:25:08Z

@copilot I can not reproduce the bug in the md, please verify that it pinpoints the exact problem

Root cause: Bun's CompressionStream("deflate") / DecompressionStream("deflate") hangs indefinitely when piped through Response streams. This blocks PNG/APNG/ICO deflate and TIFF Deflate compression. The same code works in Deno and Node.js.

Co-authored-by: Hexagon <419737+Hexagon@users.noreply.github.com> Agent-Logs-Url: https://github.com/cross-org/image/sessions/1b1ba7f0-ce77-47af-888a-de5458bfd268

Copilot · 2026-03-21T21:28:50Z

@copilot I can not reproduce the bug in the md, please verify that it pinpoints the exact problem

Root cause: Bun's CompressionStream("deflate") / DecompressionStream("deflate") han...

Removed the file in 4d69bd6. The simple CompressionStream("deflate") repro was wrong — it doesn't actually reproduce the hang. I was unable to pinpoint the exact root cause of the Bun CI timeouts from within this environment.

Hexagon · 2026-03-22T00:15:52Z

@copilot fix the failing ci by disabling bun for now

Initial plan

112e564

Copilot AI assigned Copilot and Hexagon Feb 20, 2026

Copilot started work on behalf of Hexagon February 20, 2026 22:18 View session

Fix PNG decoder: 16-bit channels, grayscale+alpha (colorType 4), and …

4cafa89

…sub-byte formats Co-authored-by: Hexagon <419737+Hexagon@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Identify and fix critical issues in the code~~ Fix PNG decoder: 16-bit channels, grayscale+alpha (colorType 4), and sub-byte formats Feb 20, 2026

Copilot AI requested a review from Hexagon February 20, 2026 22:35

Copilot finished work on behalf of Hexagon February 20, 2026 22:35

Hexagon marked this pull request as ready for review February 20, 2026 22:36

Hexagon requested a review from Copilot February 20, 2026 22:36

Copilot started reviewing on behalf of Hexagon February 20, 2026 22:37 View session

Copilot AI reviewed Feb 20, 2026

View reviewed changes

src/formats/png_base.ts Outdated Show resolved Hide resolved

Copilot started work on behalf of Hexagon February 20, 2026 22:56 View session

Make sub-byte PNG branch explicit about supported colorTypes (0 and 3)

3c7a8e5

Co-authored-by: Hexagon <419737+Hexagon@users.noreply.github.com>

Copilot finished work on behalf of Hexagon February 20, 2026 22:57

Copilot started work on behalf of Hexagon March 21, 2026 20:56 View session

Copilot AI and others added 2 commits March 21, 2026 21:04

Fix Bun CI: work around broken CompressionStream/DecompressionStream …

5896b25

…with node:zlib fallback Co-authored-by: Hexagon <419737+Hexagon@users.noreply.github.com> Agent-Logs-Url: https://github.com/cross-org/image/sessions/b9d06be4-3ef7-4982-8355-5e85e31c2768

Revert Bun workaround; add BUN_BUG_REPORT.md with minimal repro for C…

e6f28a2

…ompressionStream hang Co-authored-by: Hexagon <419737+Hexagon@users.noreply.github.com> Agent-Logs-Url: https://github.com/cross-org/image/sessions/b9d06be4-3ef7-4982-8355-5e85e31c2768

Copilot AI changed the title ~~Fix PNG decoder: 16-bit channels, grayscale+alpha (colorType 4), and sub-byte formats~~ Fix PNG decoder: 16-bit channels, grayscale+alpha (colorType 4), and sub-byte formats; add Bun bug report for CompressionStream hang Mar 21, 2026

Copilot finished work on behalf of Hexagon March 21, 2026 21:06

Copilot started work on behalf of Hexagon March 21, 2026 21:25 View session

Remove inaccurate BUN_BUG_REPORT.md — repro does not reproduce the issue

4d69bd6

Co-authored-by: Hexagon <419737+Hexagon@users.noreply.github.com> Agent-Logs-Url: https://github.com/cross-org/image/sessions/1b1ba7f0-ce77-47af-888a-de5458bfd268

Copilot AI changed the title ~~Fix PNG decoder: 16-bit channels, grayscale+alpha (colorType 4), and sub-byte formats; add Bun bug report for CompressionStream hang~~ Fix PNG decoder: 16-bit channels, grayscale+alpha (colorType 4), and sub-byte formats Mar 21, 2026

Copilot finished work on behalf of Hexagon March 21, 2026 21:29

Merge branch 'main' into copilot/fix-critical-issues

deb4b88

Hexagon merged commit 5e8fd0b into main Mar 22, 2026
3 of 5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix PNG decoder: 16-bit channels, grayscale+alpha (colorType 4), and sub-byte formats#96

Fix PNG decoder: 16-bit channels, grayscale+alpha (colorType 4), and sub-byte formats#96
Hexagon merged 7 commits intomainfrom
copilot/fix-critical-issues

Copilot AI commented Feb 20, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Hexagon commented Mar 21, 2026

Uh oh!

Copilot AI commented Mar 21, 2026

Uh oh!

Hexagon commented Mar 21, 2026

Uh oh!

Copilot AI commented Mar 21, 2026

Uh oh!

Hexagon commented Mar 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Copilot AI commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PNG Decoder Fixes (src/formats/png_base.ts)

Tests Added (test/formats/png.test.ts)

Bun CI Timeouts (not caused by this PR)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Hexagon commented Mar 21, 2026

Uh oh!

Copilot AI commented Mar 21, 2026

Uh oh!

Hexagon commented Mar 21, 2026

Uh oh!

Copilot AI commented Mar 21, 2026

Uh oh!

Hexagon commented Mar 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Feb 20, 2026 •

edited

Loading

PNG Decoder Fixes (`src/formats/png_base.ts`)

Tests Added (`test/formats/png.test.ts`)