Add missing tests for KVIndex/randomts; fix three silent bugs#19
Merged
Add missing tests for KVIndex/randomts; fix three silent bugs#19
Conversation
Co-authored-by: Hexagon <419737+Hexagon@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add tests where missing and fix found issues
Add missing tests for KVIndex/randomts; fix three silent bugs
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two source modules (
KVIndex,pseudoRandomTimestamp) had no dedicated tests. While adding coverage, three bugs were found and fixed.Bug fixes
transaction.ts— SET validation never firedcreate()checkedthis.operation === KVOperation.SETbutthis.operationisundefineduntil after that line. The guard was effectively dead code.ledger.tsvacuum — missingawaitonreadHeader()The comment read "update the header to catch new transactions" but the call was fire-and-forget, so the updated offset was never applied within the loop.
ledger.tslock — module-levelLOCKED_BYTESconstant mutated on every acquisitionconst lockBytes = LOCKED_BYTES+setBigUint64wrote the lock-ID into the shared constant's underlying buffer. Replaced withnew Uint8Array(LOCKED_BYTES_LENGTH)per call; removed the now-unused import.New tests
test/index.test.ts(22 tests) —KVIndex:add/getwith sorting, limit, reverse, numeric & string ranges, empty ranges;deleteincluding empty-parent cleanup and sibling preservation;clear;setIndex;getChildKeys.test/randomts.test.ts(6 tests) —pseudoRandomTimestamp: return type, proximity to original value, non-determinism, customnumBits, zero input, upper-bit preservation.test/transaction.test.ts— one test confirming the fixed SET/undefined guard now throws.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.