feat: add init.sh post-initialization script (#88)#158
Open
boxcee-interview wants to merge 1 commit intocrossplane:mainfrom
Open
feat: add init.sh post-initialization script (#88)#158boxcee-interview wants to merge 1 commit intocrossplane:mainfrom
boxcee-interview wants to merge 1 commit intocrossplane:mainfrom
Conversation
Add a post-initialization script that replaces all instances of function-template-python with the user's function name in: - package/crossplane.yaml (the Function resource name) - example/*.yaml (example function references) This enables the Crossplane CLI's xpkg init command to properly initialize the template by running the init.sh hook automatically. Fixes crossplane#88 Signed-off-by: Moritz Schmitz von Hülst <mschmitzvonhuelst@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #88
Add a post-initialization script that replaces all instances of
crossplane/function-template-python in the repository with the user's
own function name. This enables
xpkg initto correctly set up thetemplate after cloning.
Changes in this PR:
init.shpost-initialization script that runs automaticallyduring
xpkg initcrossplane/function-template-pythonin:package/crossplane.yaml(the Function resource name)example/aws-loadbalancer-kube-proxy-provider.yamlexample/aws-s3-bucket-provider.yamlHow to Test
xpkg init crossplane/function-template-python --target my-functionpackage/crossplane.yamlandexample/*.yamlare replaced with the new function name