Phase 3: the 3-D corkscrew walk - #3
Merged
Merged
Conversation
Lift the 2-D walk into a corkscrew and render it in matplotlib 3-D. - layout/walk3d.py: walk3d_layout — the 2-D walk in xy with a constant z lift per sentence; reuses (and stays consistent with) walk_layout. - render/mpl3d.py: render_path_3d — an mplot3d Line3DCollection path with per-segment colours and per-segment line widths (so the size channel carries into 3-D); true-proportion box aspect, clean hidden axes. - presets/text_walk.py: helix=True / z_step wind the walk into a corkscrew (path mode; glyph mode rejected in 3-D with a clear error). - Exports, example (text_walk_3d_demo.py), docs, CHANGELOG. make ci green (117 tests, incl. z-monotonicity and xy-equals-2D-walk properties); mkdocs build --strict green; corkscrew renders headlessly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 3 — 3-D corkscrew
Lifts the 2-D walk into a corkscrew and renders it with matplotlib's
mplot3d. Stacked on #2 — review/merge the chain in order, or re-target tomain.layout/walk3d.py—walk3d_layout: the 2-D walk in xy with a constantz_steplift per sentence. Reuseswalk_layout, so the corkscrew's xy is provably identical to the flat walk.render/mpl3d.py—render_path_3d: anLine3DCollectionpath with per-segment colours and per-segment line widths (the size channel carries into 3-D); true-proportion box aspect, clean hidden axes.text_walk(..., helix=True, z_step=...)— winds the same preset into a corkscrew (path mode; glyph mode is rejected in 3-D with a clear error).Verification
make cigreen: 117 tests, incl. Hypothesis properties: z increases by exactlyz_stepper step, and the corkscrew's xy equals the 2-D walk.mkdocs build --strictgreen;examples/text_walk_3d_demo.pyrenders the corkscrew headlessly (eyeballed).🤖 Generated with Claude Code