Skip to content

fix: resolve Gourmand code quality violations#89

Closed
fatherlinux wants to merge 1 commit intomasterfrom
fix/gourmand-verbose-comments
Closed

fix: resolve Gourmand code quality violations#89
fatherlinux wants to merge 1 commit intomasterfrom
fix/gourmand-verbose-comments

Conversation

@fatherlinux
Copy link
Member

Summary

  • Remove verbose inline comments from Immich integration files
  • Rename generic variable names to descriptive ones
  • Add exception for ImmichSettings.jsx HTML placeholder attribute (false positive)

Changes

  • backend/services/immichService.js: Removed 15+ verbose comments, renamed result/data to descriptive names
  • backend/scripts/migrate-poi-images.js: Removed verbose comments, renamed result to settingsQuery/poisQuery
  • backend/tests/headerButtons.integration.test.js: Removed verbose test comments
  • frontend/src/components/ThemesSettings.jsx: Removed verbose comments
  • frontend/src/hooks/useSeasonalTheme.js: Removed verbose comments, renamed data to themeConfig
  • gourmand-exceptions.toml: Added exception for ImmichSettings.jsx (HTML placeholder attribute)

Test plan

  • ./run.sh gourmand passes with 0 violations
  • GitHub Actions tests pass

🤖 Generated with Claude Code

- Remove verbose inline comments from immichService.js, migrate-poi-images.js,
  headerButtons.integration.test.js, ThemesSettings.jsx, useSeasonalTheme.js
- Rename generic variable names (result -> settingsQuery/poisQuery,
  data -> pingResponse/imageBuffer/thumbnailBuffer/themeConfig)
- Add deferred_work exception for ImmichSettings.jsx HTML placeholder attribute

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@fatherlinux
Copy link
Member Author

Closing to merge fixes directly to master

@fatherlinux fatherlinux deleted the fix/gourmand-verbose-comments branch February 10, 2026 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant