-
-
Notifications
You must be signed in to change notification settings - Fork 26
fix: limit laravel/serializable-closure to <2.0.9 #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
esetnik
wants to merge
2
commits into
crunzphp:3.9
Choose a base branch
from
esetnik:fix/limit-serializable-closure-version
base: 3.9
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,136 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Crunz\Tests\Unit\Service; | ||
|
|
||
| use Crunz\Infrastructure\Laravel\LaravelClosureSerializer; | ||
| use Crunz\Tests\TestCase\UnitTestCase; | ||
|
|
||
| final class LaravelClosureSerializerTest extends UnitTestCase | ||
| { | ||
| private LaravelClosureSerializer $serializer; | ||
|
|
||
| protected function setUp(): void | ||
| { | ||
| parent::setUp(); | ||
| $this->serializer = new LaravelClosureSerializer(); | ||
| } | ||
|
|
||
| public function test_serialize_simple_closure(): void | ||
| { | ||
| $closure = static function (): string { | ||
| return 'hello'; | ||
| }; | ||
|
|
||
| $serialized = $this->serializer->serialize($closure); | ||
| $result = $this->serializer->unserialize($serialized); | ||
|
|
||
| self::assertSame('hello', $result()); | ||
| } | ||
|
|
||
| public function test_serialize_closure_with_use_variable(): void | ||
| { | ||
| $name = 'crunz'; | ||
| $closure = static function () use ($name): string { | ||
| return "hello {$name}"; | ||
| }; | ||
|
|
||
| $serialized = $this->serializer->serialize($closure); | ||
| $result = $this->serializer->unserialize($serialized); | ||
|
|
||
| self::assertSame('hello crunz', $result()); | ||
| } | ||
|
|
||
| public function test_serialize_closure_bound_to_object_with_closure_properties(): void | ||
| { | ||
| $runner = new TaskRunnerStub(); | ||
| $closure = $runner->createTask(); | ||
|
|
||
| $serialized = $this->serializer->serialize($closure); | ||
| $result = $this->serializer->unserialize($serialized); | ||
|
|
||
| self::assertSame('running daily-report', $result()); | ||
| } | ||
|
|
||
| /** | ||
| * Regression test for laravel/serializable-closure#126. | ||
| * | ||
| * v2.0.9 skips walking properties of objects that implement __serialize, | ||
| * leaving nested closures unwrapped and causing "Serialization of 'Closure' | ||
| * is not allowed". | ||
| */ | ||
| public function test_serialize_closure_bound_to_object_with_serialize_and_closure_properties(): void | ||
| { | ||
| $runner = new TaskRunnerWithSerializeStub(); | ||
| $closure = $runner->createTask(); | ||
|
|
||
| $serialized = $this->serializer->serialize($closure); | ||
| $result = $this->serializer->unserialize($serialized); | ||
|
|
||
| self::assertSame('running daily-report', $result()); | ||
| } | ||
|
|
||
| public function test_closure_code_can_be_extracted(): void | ||
| { | ||
| $testClosure = static fn (): \stdClass => new \stdClass(); | ||
|
|
||
| $code = $this->serializer->closureCode($testClosure); | ||
|
|
||
| self::assertSame('static fn (): \stdClass => new \stdClass()', $code); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * @internal | ||
| */ | ||
| class TaskRunnerStub | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please use anonymous classes or mocks/stubs instead |
||
| { | ||
| public string $taskName = 'daily-report'; | ||
| /** @var \Closure[] */ | ||
| public array $filters = []; | ||
|
|
||
| public function createTask(): \Closure | ||
| { | ||
| $this->filters[] = static function (): bool { return true; }; | ||
|
|
||
| return function (): string { | ||
| return "running {$this->taskName}"; | ||
| }; | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * @internal | ||
| */ | ||
| class TaskRunnerWithSerializeStub | ||
| { | ||
| public string $taskName = 'daily-report'; | ||
| /** @var \Closure[] */ | ||
| public array $filters = []; | ||
|
|
||
| /** @return array{taskName: string, filters: array<\Closure>} */ | ||
| public function __serialize(): array | ||
| { | ||
| return [ | ||
| 'taskName' => $this->taskName, | ||
| 'filters' => $this->filters, | ||
| ]; | ||
| } | ||
|
|
||
| /** @param array{taskName: string, filters: array<\Closure>} $data */ | ||
| public function __unserialize(array $data): void | ||
| { | ||
| $this->taskName = $data['taskName']; | ||
| $this->filters = $data['filters']; | ||
| } | ||
|
|
||
| public function createTask(): \Closure | ||
| { | ||
| $this->filters[] = static function (): bool { return true; }; | ||
|
|
||
| return function (): string { | ||
| return "running {$this->taskName}"; | ||
| }; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use
conflictsection