Fix weekday constraints when chaining every* methods#124
Open
eyupcanakman wants to merge 4 commits intocrunzphp:3.9from
Open
Fix weekday constraints when chaining every* methods#124eyupcanakman wants to merge 4 commits intocrunzphp:3.9from
eyupcanakman wants to merge 4 commits intocrunzphp:3.9from
Conversation
eyupcanakman
force-pushed
the
fix/issue-105-weekday-between
branch
from
03afd3e to
17b5ae8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling weekday helpers before
every*methods currently resets day-of-week to*, so chains like:$task->mondays()->everyFiveMinutes()->between('08:00', '17:00')lose the weekday constraint.
This change preserves the current day-of-week segment when
every*methods apply expressions with wildcard weekday, so weekday +between()chains work correctly regardless of call order.Adds unit coverage to ensure all
every*helpers keep an existing weekday constraint.