fix(build): run NodeStarter with gradle run#966
Merged
Conversation
Align the Gradle run task with wrapper.conf by launching NodeStarter and applying required JVM flags so local runs match daemon expectations. Add runLauncher and update skills docs to keep launcher and run-task guidance explicit.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9880adedac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Set runLauncher to use the Java 25 toolchain so launcher execution matches project bytecode level instead of depending on the Gradle JVM. This prevents UnsupportedClassVersionError when Gradle runs on an older JDK.
Collaborator
Author
|
@codex review |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runto launchnetwork.crypta.node.NodeStarterand apply wrapper-aligned JVM arguments needed by the daemon path.runLauncheras an explicit application task so launcher startup remains available during development.Verification
./gradlew spotlessApply./gradlew clean classes./gradlew tasks --group application./gradlew run --args=\"--help\"./gradlew run --args=\"--version\"./gradlew runLauncher(launcher remains running; command timeout expected in CLI)