Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds a new system-wide migration function to the LexActivator library, allowing users to migrate existing license data from user-specific storage to system-wide storage. The copyright year in the LICENSE file has also been updated to reflect 2026.
Changes:
- Added
MigrateToSystemWideActivationfunction to enable migration of license data to system-wide storage - Updated native function bindings in
lexactivator_native.pyfor the new migration function - Updated LICENSE copyright year from 2025 to 2026
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| cryptlex/lexactivator/lexactivator_native.py | Added native ctypes binding for MigrateToSystemWideActivation function with c_uint32 parameter |
| cryptlex/lexactivator/lexactivator.py | Added public wrapper method MigrateToSystemWideActivation with comprehensive docstring describing usage, parameters, and return values |
| LICENSE.txt | Updated copyright year from 2025 to 2026 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| raise LexActivatorException(status) | ||
|
|
||
| @staticmethod | ||
| def MigrateToSystemWideActivation(oldPermissionFlag): |
There was a problem hiding this comment.
The parameter name 'oldPermissionFlag' uses camelCase, which is inconsistent with the codebase's naming convention. Throughout this file, parameter names consistently use snake_case (e.g., 'release_version', 'release_published_date', 'two_factor_authentication_code', 'trial_length'). The parameter should be renamed to 'old_permission_flag' to maintain consistency.
There was a problem hiding this comment.
Changing it to snake case also changing other instances where camel case was being used.
| The function does not support migration from custom data directories. | ||
|
|
||
| Args: | ||
| oldPermissionFlag (int): permission flag used previously |
There was a problem hiding this comment.
The parameter name in the docstring should match the actual parameter name used in the function signature. If the parameter is renamed to 'old_permission_flag' for consistency, this documentation should be updated accordingly.
There was a problem hiding this comment.
Changing it to snake case also changing other instances where camel case was being used.
| Returns: | ||
| int: LA_OK, LA_FAIL | ||
| """ | ||
| status = LexActivatorNative.MigrateToSystemWideActivation(oldPermissionFlag) |
There was a problem hiding this comment.
The parameter name 'oldPermissionFlag' in the native function call should match the parameter name in the function signature. If the parameter is renamed to 'old_permission_flag' for consistency with the codebase naming conventions, this reference should be updated accordingly.
There was a problem hiding this comment.
Changing it to snake case also changing other instances where camel case was being used.
|
2 participants
No description provided.