Skip to content

Ks audit #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jamshed-KS wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Ks audit #29

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f94295
Update Web3BountyContract.sol
Jamshed-KS Apr 18, 2023
b558c0f
Update Web3BountyContract.sol
Jamshed-KS Apr 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion protocols/web3storage-bounty/smart-contract/contracts/Web3BountyContract.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,8 @@ contract Web3BountyContract is Ownable, ReentrancyGuard {
deals[_deal_id].owner == msg.sender,
"Can't cancel someone else request"
);


if (deals[_deal_id].value > 0) {
// Send back payment
bool success;
Expand Down Expand Up @@ -185,7 +187,8 @@ contract Web3BountyContract is Ownable, ReentrancyGuard {
require(deals[_deal_id].timestamp_start > 0, "Deal didn't started");
require(!deals[_deal_id].claimed, "Deal claimed yet");
require(deals[_deal_id].value > 0, "Deal doesn't have value to claim");

//KS-PLW-04 Dealer can claim bounty when deal is canceled
require(!deals[_deal_id].canceled, "Deal already canceled");
// NOTE:
// _proof is maintained for compatibility purposes
// contract will not use it so we suggest to send it empty
Expand Down