Fix SetCode aliasing of input bytecode#4
Merged
anishnaik merged 1 commit intocrytic:eth-v1.15.5from Apr 20, 2026
Merged
Conversation
|
|
3 tasks
anishnaik
added a commit
to crytic/medusa
that referenced
this pull request
Apr 20, 2026
* deps: bump medusa-geth to fix vm.etch bytecode aliasing (#827) Update medusa-geth to include crytic/medusa-geth#4, which clones the input byte slice in stateObject.SetCode to prevent callers (such as vm.etch) from aliasing stored bytecode. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * nix: update vendorHash for medusa-geth bump Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a byte-slice aliasing bug in
core/state/state_object.go.Problem:
SetCodestored the caller-provided byte slice by reference instead of cloning it before storing it in state. If that slice was later mutated or reused, etched runtime bytecode could be corrupted and execution could diverge from normally deployed contracts.Fix:
Clone the input byte slice before storing it in state.
Validation:
TestSetCodeClonesInputgo test ./core/state -run TestSetCodeClonesInput -count=1vm.etchexecution diverged from the same runtime deployed normallyRelated issue: