feat: rustc-style --version with git commit and build date#509
Merged
Conversation
Contributor
Benchmark Results (Linux x86-64)
CLI Tool Benchmarks
|
a7e1f70 to
0d57698
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes
chad --versionuseful for bug reports — prints git commit and build date embedded in the version string, rustc-style as a single hyphenated token:Previously
chad 0.2.0-beta, which tells you nothing about which build someone is actually running.Also bumps version
0.2.0-beta→0.3.0-beta.How it works
scripts/gen-version.js(the existingprebuildhook) now shells out togit rev-parse --short HEADand bakes a singleVERSIONconstant of the form<semver>-<sha>-<date>intosrc/version.ts. If git isn't available (e.g., building from a release tarball), the sha falls back to"unknown".Kept the single
VERSIONexport — zero touches tosrc/*.ts, just content changes in the generatedsrc/version.ts.Test plan
node dist/chad-node.js --version→chad 0.3.0-beta-<sha>-<date>./.build/chad --version(native compiler) → samenpm run verifypasses — full tests + stage 0/1/2 self-hosting