docs: fix sqlite query/getRow examples (the <T> form alone doesn't compile)#515
Merged
docs: fix sqlite query/getRow examples (the <T> form alone doesn't compile)#515
Conversation
Contributor
Benchmark Results (Linux x86-64)
CLI Tool Benchmarks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The current sqlite docs examples don't compile. They show:
Both forms fail at the compile step — the bare
<T>type argument is silently ignored by codegen, so the result type is unknown andusers.length/user.nameproduce errors.What actually works (and what the existing fixtures use) is the variable type annotation:
The annotation drives the typed reload of the rows; the
<T>is parser noise.What changed
docs/stdlib/sqlite.md— everysqlite.query<T>(...)andsqlite.getRow<T>(...)example now uses the variable-annotation form. Headings updated accordingly.getRowexamples now show the honestUser | nullreturn type.Test plan
<T>is ignored), no annotation + no type-arg fails.tests/fixtures/builtins/sqlite-query.tsandsqlite-get-row.tscontinue to pass — they already used the annotation pattern.