Read tokens correctly from GDB's output on Windows (#55)#76
Open
barisione wants to merge 1 commit intocs01:masterfrom
Open
Read tokens correctly from GDB's output on Windows (#55)#76barisione wants to merge 1 commit intocs01:masterfrom
barisione wants to merge 1 commit intocs01:masterfrom
Conversation
Closed
1 task
Owner
|
If anyone else ends up taking this on, GitHub actions support windows, so adding a windows CI test would give good confidence in the change and ensure it doesn’t break in the future. |
Original patch by Leonardo Pereira Santos (see cs01#55); updated by Marco Barisione.
barisione
force-pushed
the
leonardopsantos-IoManager._get_responses_windows-fixes
branch
from
3d3facd to
0ef6ea1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdSummary of changes
Original patch by Leonardo Pereira Santos (see PR #55); updated by Marco Barisione.
This is the description for the original PR:
Tests don't pass on Unix and I'm reluctant to modify the code as I cannot test it on Windows so I will let this here in case anybody can help.
Fixes #54
Test plan
Tested by running
CURRENTLY FAILING ON UNIX