Add filtering of invalid intensity values in log transformation, add message to warn user#557
Open
henninggaertner wants to merge 6 commits intodevfrom
Open
Add filtering of invalid intensity values in log transformation, add message to warn user#557henninggaertner wants to merge 6 commits intodevfrom
henninggaertner wants to merge 6 commits intodevfrom
Conversation
Add message warning the user of filtered data in transformation.py.
3 tasks
Coverage reportClick to see where and how coverage changed
The report is truncated to 25 files out of 60. To see the full report, please visit the workflow summary page. This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
ronjakrg
approved these changes
Feb 3, 2025
| msg.append( | ||
| dict( | ||
| msg=f"Warning: {len(untransformable_peptide_data_df)} data points of peptide data with zero or negative intensity values were found and will be dropped. " | ||
| f"Please adapt your preprocessing pipeline if this is unexpected.", |
Collaborator
There was a problem hiding this comment.
I think we should use "workflow" here instead of "pipeline" to stay consistent? :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes #41
log(0) is infinite, which is not the desired outcome for such a value. Therefore, they need to be filtered and dropped from the data, while notifying the users about the dropped values and urging them to change their pre-processing pipeline.
Changes
Add filtering, dropping and message in
transformation.pyAdjust and add tests in
test_transformation.pyTesting
Create a run with both protein and peptide import. Then manually change some intensity values to be 0 or negative in the run's dataframe folder. Then do the log transformation with the "dirty" data.
You should see a message about the dropped data.
PR checklist
Development
Mergeability
blackCode review