Removed ffmpeg system dependency#68
Draft
GermanHydrogen wants to merge 3 commits into
Draft
Conversation
Collaborator
Author
|
Hey @cjackett , |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Refactor] Removed ffmpeg system dependency
Summary
FFMPEG is used by marimba to generate the video summary for a dataset. Currently marimba uses the FFMPEG binary made available through the $PATH environment variable. This requires FFMPEG to be installed on the system marimba is run. However marimba already comes indirectly with its own FFMPEG binaries, as marimba depends on the the package pyav, which bundles FFMPEG. This pull-request changes the calls to the ffmpeg binary to use pyav instead.
Problem
See Issue #62 for problem description
Solution
Call pyav instead of the FFMPEG binary available in $PATH.
Impact
FFMPEG is no longer a necessary system dependency, reducing the effective install-size of marimba.
However, there should not be any impact on the functionality of marimba.
Testing
No tests are modified by this PR.
Documentation
Modified the doc-strings of the changed methods.
Breaking Changes
None
Known Issues or Limitations
None
Files (Optional)
Added
None
Modified
Removed
None
Notes to Reviewer
There is still code left in marimba, which checks for the existence of ffmpeg in $PATH. This code will still need to be removed for the branch to be cleanly merge able.
The current state reflects the changes necessary to run the https://github.com/csiro-fair/mritc-demo-pipeline without FFMPEG beeing installed.
I used the following dockerfile to test this: