fix: defend against process object being deleted#48
Open
isaacs wants to merge 1 commit intocspotcode:masterfrom
Open
fix: defend against process object being deleted#48isaacs wants to merge 1 commit intocspotcode:masterfrom
isaacs wants to merge 1 commit intocspotcode:masterfrom
Conversation
Occasionally test files will do weird stuff, like setting the `process` global to null, or to some other value. Grab a reference to the process global as soon as the module is loaded, so that we don't end up trying to reference something that's gone or reassigned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Occasionally test files will do weird stuff, like setting the
processglobal to null, or to some other value.Grab a reference to the process global as soon as the module is loaded, so that we don't end up trying to reference something that's gone or reassigned.
This is important for node-tap, because tests need to handle this sort of bad behavior gracefully.