Merged
Conversation
…into feat/frontend-agent-pipeline
…pon adding agent in pipeline, integrated the options for displaying all the disconnected agents
…into feat/frontend-agent-pipeline
…dynamic rendering for source config
…i calls and some minor changes
legendary-acp
suggested changes
Mar 31, 2025
Contributor
legendary-acp
left a comment
legendary-acp
left a comment
There was a problem hiding this comment.
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: @jsonforms/material-renderers@3.5.1
npm ERR! Found: @mui/icons-material@7.0.1
npm ERR! node_modules/@mui/icons-material
npm ERR! @mui/icons-material@"^7.0.1" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @mui/icons-material@"^5.11.16 || ^6.0.0" from @jsonforms/material-renderers@3.5.1
npm ERR! node_modules/@jsonforms/material-renderers
npm ERR! @jsonforms/material-renderers@"^3.5.1" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: @mui/icons-material@6.4.9
npm ERR! node_modules/@mui/icons-material
npm ERR! peer @mui/icons-material@"^5.11.16 || ^6.0.0" from @jsonforms/material-renderers@3.5.1
npm ERR! node_modules/@jsonforms/material-renderers
npm ERR! @jsonforms/material-renderers@"^3.5.1" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR!
npm ERR! For a full report see:
npm ERR! /Users/pradyuman/.npm/_logs/2025-03-31T17_19_34_797Z-eresolve-report.txt
npm ERR! A complete log of this run can be found in: /Users/pradyuman/.npm/_logs/2025-03-31T17_19_34_797Z-debug-0.log
there is still some package conflicts on fresh setup. Fix these
| import axios, { AxiosError } from 'axios'; | ||
| import { AxiosError } from 'axios'; | ||
|
|
||
| const apiUrl = "http://localhost:8096" |
Contributor
There was a problem hiding this comment.
Read apiUrl from env file. Not hardcoded
Contributor
Backend is being called for agent and pipeline page twice for a single request
|
Contributor
Both add source and destination are hardcoded. Need to be fetched dynamically from backend
|
legendary-acp
suggested changes
Apr 1, 2025
Contributor
legendary-acp
left a comment
legendary-acp
left a comment
There was a problem hiding this comment.
I have added some comments, Please fix them
…into feat/frontend-agent-pipeline
…for improved reliability
…te queue initialization
…ID and tokens; refactor related methods
…n and processor forms and options in pipeline canvas view
…base queries; add utility functions for string manipulation
…; refactor related logic for consistency
…eating onboarding flow, integrated jsonforms
…lb-hq/ctrlb-control-plane into feat/frontend-agent-pipeline
…f sources and nodes
…lb-hq/ctrlb-control-plane into feat/frontend-agent-pipeline
… and ctrlb-control-plane-backend
legendary-acp
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the Readme file for frontend folder, added axios interceptors for processing requests and some minor changes.