fix: use list oss vcluster from loft library

[adityachoudhari26]

Summary by CodeRabbit

• Refactor
  • Improved the method for discovering vclusters by utilizing Kubernetes client configuration directly, resulting in a more streamlined and robust process.
• Chores
  • Updated dependency management to mark certain logging libraries as indirect dependencies.

[coderabbitai]

Walkthrough

The changes update the method for listing vclusters by switching from a logger-based approach to one that utilizes a Kubernetes clientset and context. Additionally, the dependency declarations for logging libraries are moved from direct to indirect in the module configuration, reflecting their new usage status.

Changes

File(s)	Change Summary
cmd/ctrlc/root/sync/kubernetes/vcluster.go	Replaced logger-based vcluster listing with clientset/context-based approach; updated error handling.
go.mod	Moved github.com/loft-sh/log and github.com/sirupsen/logrus from direct to indirect dependencies.

Poem

A hop and a skip through the vcluster field,
Now with clientsets, our secrets revealed!
The logger takes a gentle rest,
Indirect friends still on our quest.
With cleaner code and modules neat,
This rabbit’s work is quite a treat! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 001d37c and 0812692.

📒 Files selected for processing (2)

• cmd/ctrlc/root/sync/kubernetes/vcluster.go (2 hunks)
• go.mod (2 hunks)

🔇 Additional comments (5)

go.mod (1)

138-138: LGTM! Dependency management aligns with code changes.

Moving the logging dependencies (github.com/loft-sh/log and github.com/sirupsen/logrus) from direct to indirect correctly reflects the removal of direct logger usage in the vcluster listing functionality.

Also applies to: 173-173

cmd/ctrlc/root/sync/kubernetes/vcluster.go (4)

15-15: Import addition looks good.

The new import for github.com/loft-sh/vcluster/pkg/platform/kube is appropriate for the clientset-based vcluster listing approach.

---

142-145: Clientset creation implementation is correct.

The clientset creation using kube.NewForConfig(config) and error handling follow good practices.

---

148-148: Function call update aligns with PR objectives.

The change from find.ListVClusters() to find.ListOSSVClusters(cmd.Context(), clientset, context, "", namespace) correctly implements the OSS vcluster listing approach using the Kubernetes clientset instead of a logger-based method.

---

137-140:

Details

✅ Verification successful

Verify that getKubeConfig() function exists.

The kubeconfig retrieval logic and error handling look correct. However, please ensure that the getKubeConfig() function is properly defined and accessible in this package.

---

🏁 Script executed:

#!/bin/bash
# Description: Search for getKubeConfig function definition to ensure it exists
# Expected: Function should be defined in the codebase

ast-grep --pattern 'func getKubeConfig() ($_) {
  $$$
}'

# Also search for any getKubeConfig function variations
rg -A 5 "func.*getKubeConfig"

Length of output: 661

---

getKubeConfig() definition verified

The getKubeConfig() function is implemented in cmd/ctrlc/root/sync/kubernetes/client.go as func getKubeConfig() (*rest.Config, string, error) and is part of the same package, so it’s accessible from vcluster.go.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.