fix: filter aws vpc/subnet calls with accountId

[dacbd]

Summary by CodeRabbit

• Bug Fixes
  • Improved AWS network resource synchronization with enhanced account-level filtering for VPCs and subnets, ensuring accurate resource retrieval and proper account ownership alignment during sync operations.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request adds account-based filtering to AWS network synchronization operations. The getAwsSubnets function signature is updated to accept accountId as a parameter, and owner-based filters are applied when listing both VPCs and subnets to align resources with their owning account.

Changes

Cohort / File(s)	Summary
AWS Network Filtering cmd/ctrlc/root/sync/aws/networks/networks.go	Updated getAwsSubnets function signature to include accountId parameter. Added owner-based filtering to VPC and subnet listing operations using getOwnerFilter(accountId) to ensure resources are associated with their owning account during synchronization.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• aws/az network scans #26: Modifies the same AWS networks file to pass accountId into getAwsSubnets and implements owner/account-based filters for VPC and subnet listing—directly addresses the same function signatures and filtering logic.

Poem

🐰 A rabbit hops through cloud accounts with glee,
Filtering subnets to where they should be,
Owner tags guide the synchronization dance,
AWS networks aligned at a glance! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: adding accountId-based filtering to AWS VPC and subnet API calls.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch dacbd/filter-aws-ownership

Tip

🧪 Unit Test Generation v2 is now available!

We have significantly improved our unit test generation capabilities.

To enable: Add this to your .coderabbit.yaml configuration:

reviews:
  finishing_touches:
    unit_tests:
      enabled: true

Try it out by using the @coderabbitai generate unit tests command on your code files or under ✨ Finishing Touches on the walkthrough!

Have feedback? Share your thoughts on our Discord thread!

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}