refactor: migrate resource variables to db

apps/workspace-engine/pkg/db/queries/resource_variables.sql

@@ -0,0 +1,29 @@
+-- name: GetResourceVariable :one
+SELECT resource_id, key, value
+FROM resource_variable
+WHERE resource_id = $1 AND key = $2;
+
+-- name: UpsertResourceVariable :exec
+INSERT INTO resource_variable (resource_id, key, value)
+VALUES ($1, $2, $3)
+ON CONFLICT (resource_id, key) DO UPDATE
+SET value = EXCLUDED.value;
+
+-- name: DeleteResourceVariable :exec
+DELETE FROM resource_variable
+WHERE resource_id = $1 AND key = $2;
+
+-- name: ListResourceVariablesByResourceID :many
+SELECT resource_id, key, value
+FROM resource_variable
+WHERE resource_id = $1;
+
+-- name: DeleteResourceVariablesByResourceID :exec
+DELETE FROM resource_variable
+WHERE resource_id = $1;
+
+-- name: ListResourceVariablesByWorkspaceID :many
+SELECT rv.resource_id, rv.key, rv.value
+FROM resource_variable rv
+INNER JOIN resource r ON r.id = rv.resource_id
+WHERE r.workspace_id = $1;

apps/workspace-engine/pkg/db/queries/schema.sql

@@ -231,4 +231,11 @@ CREATE TABLE user_approval_record (
     reason TEXT,
     created_at TIMESTAMPTZ NOT NULL DEFAULT NOW(),
     PRIMARY KEY (version_id, user_id, environment_id)
+);
+
+CREATE TABLE resource_variable (
+    resource_id UUID NOT NULL REFERENCES resource(id) ON DELETE CASCADE,
+    key TEXT NOT NULL,
+    value JSONB NOT NULL,
+    PRIMARY KEY (resource_id, key)
 );

apps/workspace-engine/pkg/db/sqlc.yaml

@@ -20,6 +20,7 @@ sql:
       - queries/changelog.sql
       - queries/policies.sql
       - queries/user_approval_records.sql
+      - queries/resource_variables.sql
     database:
       uri: "postgresql://ctrlplane:ctrlplane@127.0.0.1:5432/ctrlplane?sslmode=disable"
     gen:
@@ -98,3 +99,8 @@ sql:
           - column: "policy_rule_verification.metrics"
             go_type:
               type: "[]byte"
+
+          # ResourceVariable
+          - column: "resource_variable.value"
+            go_type:
+              type: "[]byte"

apps/workspace-engine/pkg/persistence/integration_test.go

@@ -469,7 +469,7 @@ func TestPersistence_AllEntityTypes(t *testing.T) {
 	_, ok = testStore.Repo().ResourceProviders().Get(resourceProvider.Id)
 	assert.True(t, ok, "ResourceProvider should be restored")
 
-	_, ok = testStore.Repo().ResourceVariables.Get(resourceVariable.ID())
+	_, ok = testStore.Repo().ResourceVariables().Get(resourceVariable.ID())
 	assert.True(t, ok, "ResourceVariable should be restored")
 
 	_, ok = testStore.Repo().Deployments().Get(deploymentId)

apps/workspace-engine/pkg/workspace/store/repository/db/repo.go

@@ -11,6 +11,7 @@ import (
 	"workspace-engine/pkg/workspace/store/repository/db/releases"
 	"workspace-engine/pkg/workspace/store/repository/db/resourceproviders"
 	"workspace-engine/pkg/workspace/store/repository/db/resources"
+	"workspace-engine/pkg/workspace/store/repository/db/resourcevariables"
 	"workspace-engine/pkg/workspace/store/repository/db/systemdeployments"
 	"workspace-engine/pkg/workspace/store/repository/db/systemenvironments"
 	"workspace-engine/pkg/workspace/store/repository/db/systems"
@@ -30,6 +31,7 @@ type DBRepo struct {
 	systemEnvironments  repository.SystemEnvironmentRepo
 	policies            repository.PolicyRepo
 	userApprovalRecords repository.UserApprovalRecordRepo
+	resourceVariables   repository.ResourceVariableRepo
 }
 
 func (d *DBRepo) DeploymentVersions() repository.DeploymentVersionRepo {
@@ -80,6 +82,10 @@ func (d *DBRepo) UserApprovalRecords() repository.UserApprovalRecordRepo {
 	return d.userApprovalRecords
 }
 
+func (d *DBRepo) ResourceVariables() repository.ResourceVariableRepo {
+	return d.resourceVariables
+}
+
 func NewDBRepo(ctx context.Context, workspaceID string) *DBRepo {
 	return &DBRepo{
 		deploymentVersions:  deploymentversions.NewRepo(ctx, workspaceID),
@@ -94,5 +100,6 @@ func NewDBRepo(ctx context.Context, workspaceID string) *DBRepo {
 		systemEnvironments:  systemenvironments.NewRepo(ctx),
 		policies:            policies.NewRepo(ctx, workspaceID),
 		userApprovalRecords: userapprovalrecords.NewRepo(ctx),
+		resourceVariables:   resourcevariables.NewRepo(ctx, workspaceID),
 	}
 }

apps/workspace-engine/pkg/workspace/store/repository/db/resourcevariables/mapper.go

@@ -0,0 +1,49 @@
+package resourcevariables
+
+import (
+	"fmt"
+	"workspace-engine/pkg/db"
+	"workspace-engine/pkg/oapi"
+
+	"github.com/google/uuid"
+)
+
+func ToOapi(row db.ResourceVariable) *oapi.ResourceVariable {
+	value := oapi.Value{}
+	_ = value.UnmarshalJSON(row.Value)
+
+	return &oapi.ResourceVariable{
+		ResourceId: row.ResourceID.String(),
+		Key:        row.Key,
+		Value:      value,
+	}
+}
+
+func ToUpsertParams(e *oapi.ResourceVariable) (db.UpsertResourceVariableParams, error) {
+	rid, err := uuid.Parse(e.ResourceId)
+	if err != nil {
+		return db.UpsertResourceVariableParams{}, fmt.Errorf("parse resource_id: %w", err)
+	}
+
+	valueBytes, err := e.Value.MarshalJSON()
+	if err != nil {
+		return db.UpsertResourceVariableParams{}, fmt.Errorf("marshal value: %w", err)
+	}
+
+	return db.UpsertResourceVariableParams{
+		ResourceID: rid,
+		Key:        e.Key,
+		Value:      valueBytes,
+	}, nil
+}
+
+func parseKey(key string) (uuid.UUID, string, error) {
+	if len(key) < 38 || key[36] != '-' {
+		return uuid.Nil, "", fmt.Errorf("invalid resource variable key: %q", key)
+	}
+	rid, err := uuid.Parse(key[:36])
+	if err != nil {
+		return uuid.Nil, "", fmt.Errorf("parse resource_id from key: %w", err)
+	}
+	return rid, key[37:], nil
+}