Open
Conversation
…able to allow it to embed a batch of images and repeat them in any order over a number of frames
# Conflicts: # IPAdapterPlus.py
Owner
|
Thanks for your suggestions! this is something I'm experimenting too but I want to try a slightly different approach. The expensive bit is the image encoding itself. That can be easily solved by batching the encoder, once encoded I would keep all the embeds in the regular ram, ready to be used. That keeps the code pretty simple and doesn't touch the image encoder itself (which is important because we need to keep it aligned with comfyui's updates) Once we enter the diffusion process everything is moved to the vram, instead of doing that we still keep them into regular ram and move them to vram 16 at the time (or whatever is the context window). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some memory optimization ideas in this PR: