Open
Conversation
|
@cubiq any thoughts regarding this? will you merge this PR once the conflicts will be resolved or did you want a different approach? I would like to request the same feature support for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In response to issue #367
I modified the
insightface_loaderfunction to have this behavior:extra_model_paths.yamlfileSome remarks:
Comfy/models/insightfacebefore adding an entry in the yaml file, it will download it in the new place (under yaml_path/models/buffalo_l)
So, you will have a duplication of the model and have to delete the old one manually.
FaceAnalysisclass. So I think it doesn't adress@zulfadzlie remark about "antelopev2" and "buffalo_l" usage. If we want to be able to use an other insightface model
, it should be made in an other PR I think.