Open
Conversation
Owner
|
for the batch option you need to add but for the attention masking I need to do some testing with animations |
Author
|
lol oops typo, tested with the unfold_batch = True but ctrl-z'ed before commit. was working for weight scheduling + regional conditioning, did not test attn masking |
Author
|
hm, doesn't seem to work with regional conditioning when trying to use weight scheduling on one ipa while the other has constant weight. Will check it out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates a new node,
IPAdapterFromParamsBatch, which inherits from IPAdapterBatch.It was previously impossible to use weight schedules with the
IPAdapterFromParamsnode asunfold_batchwas not enabled.