feat: support bool type parameter in step functions#761
Open
StevenHuangYH wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds first-class support for bool parameters in step handler functions, enabling automatic conversion of matched step arguments into Go booleans during step execution.
Changes:
- Extend
StepDefinition.Run()argument conversion to handlereflect.Boolviastrconv.ParseBool. - Add a dedicated test validating bool parsing and invalid bool conversion errors.
- Update the “invalid handler param” test to no longer treat
boolas an unsupported parameter type.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/models/stepdef.go | Adds bool argument parsing using strconv.ParseBool in the step invocation conversion switch. |
| internal/models/stepdef_test.go | Adds coverage for bool parameters and updates unsupported-type expectations accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
This PR adds support for
boolas a parameter type in step handler functions.Previously, using
boolin a step function would result in:Now you can write step definitions like:
How it works
Uses
strconv.ParseBoolwhich accepts the following string values:true:"1","t","T","TRUE","true","True"false:"0","f","F","FALSE","false","False"Changes
internal/models/stepdef.go: Addedreflect.Boolcase in theRun()type switchinternal/models/stepdef_test.go: AddedTestShouldSupportBoolTypetest and updated the invalid-type test to reflect thatboolis now supportedRelated
Related to #747 (optional parameters for int/uint/float types)