Skip to content

chore: add package-lock.json for sdk quickstart dependencies#30

Open
Jona10i wants to merge 1 commit intocursor:mainfrom
Jona10i:main
Open

chore: add package-lock.json for sdk quickstart dependencies#30
Jona10i wants to merge 1 commit intocursor:mainfrom
Jona10i:main

Conversation

@Jona10i
Copy link
Copy Markdown

@Jona10i Jona10i commented May 8, 2026

Note

Low Risk
Adds a lockfile for the sdk/quickstart Node project; no runtime/app logic changes. Risk is limited to dependency resolution and potential tooling mismatch (project declares pnpm but now includes an npm lockfile).

Overview
Adds sdk/quickstart/package-lock.json (lockfile v3) to pin the quickstart’s Node dependencies/devDependencies (notably @cursor/sdk, typescript, tsx, and transitive deps) for reproducible installs.

Reviewed by Cursor Bugbot for commit 3816f98. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high mode and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 3816f98. Configure here.

"@cursor/sdk-linux-arm64": "1.0.12",
"@cursor/sdk-linux-x64": "1.0.12",
"@cursor/sdk-win32-x64": "1.0.12"
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dual lockfiles resolve different SDK versions

Medium Severity · Code Quality

The new package-lock.json resolves @cursor/sdk to version 1.0.12, which conflicts with the 1.0.7 version pinned in pnpm-lock.yaml. This creates inconsistent SDK versions for contributors, depending on whether they use npm ci or pnpm install. Given the project's explicit pnpm configuration, this undermines reproducibility and can lead to dependency drift.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 3816f98. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant