Merged
Conversation
pokey
force-pushed
the
pokey/query-hot-reloading-during-development
branch
from
772b512 to
c03c303
Compare
pokey
commented
Aug 17, 2023
| const languageDefinitions = new LanguageDefinitions(treeSitter); | ||
| const languageDefinitions = new LanguageDefinitions(fileSystem, treeSitter); | ||
|
|
||
| ide.disposeOnExit(rangeUpdater, languageDefinitions, hatTokenMap, debug); |
Member
Author
There was a problem hiding this comment.
whoops; looks like we forgot to dispose a bunch of stuff 😅
| message, | ||
| ); | ||
|
|
||
| if (ide().runMode === "test") { |
Member
Author
There was a problem hiding this comment.
Development is much easier if you can see the scopes that allow-multiple is complaining about. If you fail, you can't see anything so it's really hard to debug
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 18, 2023
- Required by #1803 - Required by #1663 ## Checklist - [ ] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [ ] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [ ] I have not broken the cheatsheet
AndreasArvidsson
approved these changes
Aug 18, 2023
pokey
force-pushed
the
pokey/query-hot-reloading-during-development
branch
from
c03c303 to
f640f98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist