Skip to content

🧹 remove unused BlockPos import from BlockCompressor#12

Merged
cuspymd merged 1 commit intomainfrom
cleanup-block-compressor-imports-12910862265779275597
Mar 21, 2026
Merged

🧹 remove unused BlockPos import from BlockCompressor#12
cuspymd merged 1 commit intomainfrom
cleanup-block-compressor-imports-12910862265779275597

Conversation

@cuspymd
Copy link
Owner

@cuspymd cuspymd commented Mar 20, 2026

This PR removes an unused import in BlockCompressor.java.

🎯 What: Removed import net.minecraft.util.math.BlockPos; from src/main/java/cuspymd/mcp/mod/utils/BlockCompressor.java.
💡 Why: The import was unused as the class uses its own internal representations for block coordinates, which helps maintain a cleaner codebase and avoids unnecessary dependencies on Minecraft classes where not needed.
Verification: Manually verified that BlockPos is not used in the file. Existing code already uses int x, y, z fields in BlockData and BlockPosition classes.
Result: Cleaner code and slightly improved maintainability.


PR created automatically by Jules for task 12910862265779275597 started by @cuspymd

The `BlockCompressor` class was importing `net.minecraft.util.math.BlockPos` but not using it. All coordinate data is handled through the internal `BlockData` and `BlockPosition` classes using primitive `int` fields. Removing this import improves code cleanliness and reduces unnecessary dependencies.

Co-authored-by: cuspymd <8870299+cuspymd@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@cuspymd cuspymd merged commit 1c0814d into main Mar 21, 2026
2 checks passed
@cuspymd cuspymd deleted the cleanup-block-compressor-imports-12910862265779275597 branch March 21, 2026 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant