Update jquery.visible.js - dealing with elements larger than window height#16
Open
danielszanto wants to merge 1 commit intocustomd:masterfrom
Open
Update jquery.visible.js - dealing with elements larger than window height#16danielszanto wants to merge 1 commit intocustomd:masterfrom
danielszanto wants to merge 1 commit intocustomd:masterfrom
Conversation
If the element is larger than the window it will register as not visible when edges are off screen. To fix this I added checks if element top is above screen top && element bottom is below screen bottom. The non-native method is rather ugly
There was a problem hiding this comment.
👍 I just made this same change in my local clone. Didn't have to look at the non native implementation because I don't have to support browsers without getBoundingClientRect :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the element is larger than the window it will register as not visible when edges are off screen. To fix this I added checks if element top is above screen top && element bottom is below screen bottom.
The non-native method is rather ugly