Refactored and added getFullOffsets() / visibleFromParentAndOffset()#27
Open
picoded wants to merge 3 commits intocustomd:masterfrom
Open
Refactored and added getFullOffsets() / visibleFromParentAndOffset()#27picoded wants to merge 3 commits intocustomd:masterfrom
picoded wants to merge 3 commits intocustomd:masterfrom
Conversation
…ex parent views. And/or offsets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of function changes
getFullOffsets
gets the full top,left,bottom,right offsets relative to the top,left corner of the browser. With an optional delta adjustment of results. Also returns object width / height.
visibleFromParentAndOffset
Extends the original visible function, to check relative to a parent view box, and its offsets
visible
original visible functionality parameters list by Sam Sehnert (backwards compatible)