Allow action and dynamicLayout as root template nodes#30
Merged
Conversation
The template schema previously restricted root to layout nodes only. This adds a rootNode definition that allows all three container types (layout, action, dynamicLayout) as root, with a new "card" example template demonstrating action-as-root. Fixes iOS renderer to properly expand horizontal layout children (matching web flex:1 and Android weight(1f)) and replaces the Button- based action view with a VStack + onTapGesture so width propagates correctly to children. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The renderer changes (needsFlex, action view rewrite) affect existing templates but snapshots should be re-recorded on CI to match the pinned runner environment. Only the new card snapshots are included. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Paparazzi's layoutlib can't render Coil AsyncImage content, so images were blank in all Android snapshots. Switched to LocalJistImageProvider with a synchronous ImageBitmap placeholder, bypassing AsyncImage entirely. Removed unused coil-test dependency. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…03523 Update snapshot baselines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rootNodeschema definition allowinglayout,action, anddynamicLayoutas root — previously onlylayoutwas permittedflex:1and Androidweight(1f)), and action view usesVStack+onTapGestureinstead ofButtonso width propagates correctlyChanges
rootNodeoneOf definition, updated root descriptionJistActionViewrewritten as tappable VStack;JistLayoutViewgainsneedsFlexfor horizontal layout children;JistViewapplies full-width frame to root nodecardtemplate + data added to templates.json/data.jsonTest plan
🤖 Generated with Claude Code