Skip to content

feat: Lobby popup #1349

Merged
itsalaidbacklife merged 12 commits into
mainfrom
haviles04/feat-1326
May 1, 2026
Merged

feat: Lobby popup #1349
itsalaidbacklife merged 12 commits into
mainfrom
haviles04/feat-1326

Conversation

@Haviles04
Copy link
Copy Markdown
Contributor

@Haviles04 Haviles04 commented Apr 15, 2026 •
edited
Loading

Issue number

Relevant issue number

Please check the following

  • Do the tests still pass? (see Run the Tests)
  • Is the code formatted properly? (see Linting (Formatting))
  • For New Features:
    • Have tests been added to cover any new features or fixes?
    • Has the documentation been updated accordingly?

Please describe additional details for testing this change

Haviles04
Haviles04 commented Apr 15, 2026
View reviewed changes
Comment thread tests/e2e/specs/out-of-game/lobby.spec.js
itsalaidbacklife
itsalaidbacklife reviewed Apr 15, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@itsalaidbacklife itsalaidbacklife left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

Comment thread src/routes/lobby/components/PlayTimeDialog.vue Outdated
Comment thread src/routes/lobby/components/PlayTimeDialog.vue Outdated
Comment thread tests/e2e/specs/out-of-game/lobby.spec.js Outdated
Haviles04 and others added 2 commits April 22, 2026 11:35
@Haviles04
Merge branch 'main' into haviles04/feat-1326
6f752e6
@Haviles04 @claude
fix: address PR feedback for play time dialog
130a159 
- Replace i18n-t with span in PlayTimeDialog
- Add cy.dismissIntroPopups command for shared popup setup
- Migrate specs to use the new command
- Add negative test confirming dialog stays hidden when dismissed

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Haviles04
Haviles04 commented Apr 29, 2026
View reviewed changes
Comment thread tests/e2e/specs/out-of-game/lobby.spec.js
@itsalaidbacklife itsalaidbacklife added version-minor An update that warrants a bumping the project's minor version (e.g. 4.0.0 => 4.1.0) frontend Requires changes to the frontend (vue) client labels May 1, 2026
itsalaidbacklife
itsalaidbacklife previously approved these changes May 1, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@itsalaidbacklife itsalaidbacklife left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit left to import the local storage key name variables in the commands file. Could you also write up the issue to implement cy.clock() to avoid long waits in the relevant tests? Then we're good

Comment thread tests/e2e/support/commands.js Outdated
@Haviles04 Haviles04 requested a review from itsalaidbacklife May 1, 2026 12:38
@Haviles04
Copy link
Copy Markdown
Contributor Author

Haviles04 commented May 1, 2026 •
edited
Loading

#1357 written to investigate/fix cy.wait

@itsalaidbacklife itsalaidbacklife merged commit 16ea507 into main May 1, 2026
9 checks passed
@itsalaidbacklife itsalaidbacklife deleted the haviles04/feat-1326 branch May 1, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itsalaidbacklife itsalaidbacklife itsalaidbacklife approved these changes

Assignees

No one assigned

Labels

frontend Requires changes to the frontend (vue) client version-minor An update that warrants a bumping the project's minor version (e.g. 4.0.0 => 4.1.0)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature]: Create popup in LobbyView to explain how to join events if player is sitting in lobby for over 1 minute

2 participants

@Haviles04 @itsalaidbacklife