Feat/hand limit rework

.claude/rules/translation-parity.md

@@ -0,0 +1,18 @@
+---
+paths:
+  - "src/translations/*.json"
+---
+
+## Translation File Parity
+
+All JSON files in this directory must have identical keys in identical order at all times.
+
+Before editing any translation file, read all other files in this directory to understand the current key set and order.
+
+When adding a key: add it at the same position in every file, with the value translated into each file's language (e.g. English in en.json, French in fr.json).
+
+When deleting a key: delete it from every file.
+
+When changing a value: update the corresponding translation in every other file so the meaning stays in sync across languages.
+
+This applies whether translation changes are the primary task or incidental to a larger change.

.gitignore

@@ -150,7 +150,6 @@ storybook-static
 #
 # Files generated by AI assistants
 ################################################
-.claude*
-.cursor*
-.gemini*
+.gemini/tmp/
+.gemini/.env
 

AGENTS.md

@@ -67,6 +67,8 @@ In case of conflicting rules, the following hierarchy applies:
 - **Discovery**: Glob `src/components` for shared, general-purpose components. Page-specific components are often located in `src/routes/[routeName]/components/`. Page entry points are in `src/routes/[routeName]/[RouteName]View.vue`.
 - **UI Library**: Vuetify is used. See existing components for usage patterns.
 - **Routing**: `src/router.js` defines routes and navigation guards.
+- **State Management**: Pinia is used for state management; stores are located in `src/stores` and use the setup store syntax
+- **Syntax** Use `<script setup>` for all new vue components
 
 ### Backend (Sails.js)
 - **Routes**: `config/routes.js` maps endpoints to controller actions.
@@ -123,9 +125,4 @@ Before completing any task, verify:
 1.  **Discovery**: Confirm your implementation matches discovered patterns.
 2.  **Security**: No secrets hardcoded; policies are correctly applied.
 3.  **Pattern Consistency**: Changes align with existing file and project structures.
-4.  **Automated Checks**: Run `npm run lint` and `npm run test:unit`.
-
----
-
-**Remember**: You are a discovery system first, a code generator second. When in doubt, search, read, and ask questions before writing code.
-
+4.  **Automated Checks**: Run `npm run lint` to verify code style

api/helpers/game-states/ai/get-move-bodies-for-move-type.js

@@ -140,6 +140,27 @@ module.exports = {
         }
         break;
 
+      case MoveType.DISCARD_TO_HAND_LIMIT: {
+        const overflowCount = playerHand.length - 8;
+        if (overflowCount <= 0) {break;}
+        const getCombinations = (arr, k) => {
+          if (k === 1) {return arr.map((item) => [ item ]);}
+          const result = [];
+          for (let i = 0; i <= arr.length - k; i++) {
+            for (const rest of getCombinations(arr.slice(i + 1), k - 1)) {
+              result.push([ arr[i], ...rest ]);
+            }
+          }
+          return result;
+        };
+        res = getCombinations(playerHand, overflowCount).map((combo) => ({
+          moveType,
+          playedBy,
+          discardedCards: combo.map((card) => card.id),
+        }));
+        break;
+      }
+
       case MoveType.SEVEN_POINTS:
         res = deck.slice(0, 2)
           .filter((card) => card.rank <= 10)

api/helpers/game-states/get-active-player-p-num.js

@@ -31,6 +31,9 @@ module.exports = {
       case GamePhase.RESOLVING_FOUR:
         return exits.success((currentState.turn + 1) % 2);
 
+      case GamePhase.DISCARDING_TO_HAND_LIMIT:
+        return exits.success(currentState.p0.hand.length > 8 ? 0 : 1);
+
       case GamePhase.CONSIDERING_STALEMATE:
         return exits.success((currentState.playedBy + 1) % 2);
 

api/helpers/game-states/get-log.js

@@ -120,6 +120,11 @@ module.exports = {
             discardedCards.length > 1 ? `and the ${getFullCardName(discardedCards[1])}.` : '.'
           }`;
 
+        case MoveType.DISCARD_TO_HAND_LIMIT:
+          return `${player} discarded the ${getFullCardName(discardedCards[0])} ${
+            discardedCards.length > 1 ? `and the ${getFullCardName(discardedCards[1])} ` : ''
+          }to the hand limit.`;
+
         case MoveType.RESOLVE_FIVE:
           if (discardedCards.length) {
             return `${player} discarded the ${getFullCardName(

api/helpers/game-states/moves/discard-to-hand-limit/execute.js

@@ -0,0 +1,65 @@
+const GamePhase = require('../../../../../utils/GamePhase.json');
+
+module.exports = {
+  friendlyName: 'Discard to hand limit',
+
+  description: 'Returns new GameState resulting from a player discarding excess cards to reach the hand limit',
+
+  inputs: {
+    currentState: {
+      type: 'ref',
+      description: 'The latest GameState before the requesting player discards excess cards',
+      required: true,
+    },
+    /**
+     * @param { Object } requestedMove - Object describing the request to discard to hand limit
+     * @param { string[] } requestedMove.discardedCards - IDs of cards to discard (exactly hand.length - 8)
+     * @param { MoveType.DISCARD_TO_HAND_LIMIT } requestedMove.moveType
+     */
+    requestedMove: {
+      type: 'ref',
+      description: 'The move being requested.',
+    },
+    playedBy: {
+      type: 'number',
+      description: 'Player number of player requesting move.',
+    },
+    priorStates: {
+      type: 'ref',
+      description: 'List of packed gameStateRows for this game\'s prior states',
+      required: true,
+    }
+  },
+  sync: true,
+  fn: ({ currentState, requestedMove, playedBy }, exits) => {
+    const { discardedCards: discardIds } = requestedMove;
+    let result = _.cloneDeep(currentState);
+
+    const player = playedBy ? result.p1 : result.p0;
+    const discardedCards = [];
+
+    for (const cardId of discardIds) {
+      const cardIndex = player.hand.findIndex(({ id }) => id === cardId);
+      if (cardIndex !== -1) {
+        discardedCards.push(player.hand[cardIndex]);
+        result.scrap.push(...player.hand.splice(cardIndex, 1));
+      }
+    }
+
+    result.turn++;
+
+    result = {
+      ...result,
+      ...requestedMove,
+      phase: GamePhase.MAIN,
+      playedBy,
+      playedCard: null,
+      targetCard: null,
+      discardedCards,
+      resolved: null,
+      oneOff: null,
+    };
+
+    return exits.success(result);
+  },
+};

api/helpers/game-states/moves/discard-to-hand-limit/validate.js

@@ -0,0 +1,72 @@
+const GamePhase = require('../../../../../utils/GamePhase.json');
+const BadRequestError = require('../../../../errors/badRequestError');
+
+module.exports = {
+  friendlyName: 'Validate request to discard to hand limit',
+
+  description: 'Verifies whether a request to discard excess cards is legal, throwing explanatory error if not.',
+
+  inputs: {
+    currentState: {
+      type: 'ref',
+      descriptions: 'Object containing the current game state',
+      required: true,
+    },
+    /**
+     * @param { Object } requestedMove - Object describing the request to discard to hand limit
+     * @param { string[] } requestedMove.discardedCards - IDs of cards to discard (must equal hand.length - 8)
+     * @param { MoveType.DISCARD_TO_HAND_LIMIT } requestedMove.moveType
+     */
+    requestedMove: {
+      type: 'ref',
+      description: 'Object containing data needed for current move',
+      required: true,
+    },
+    playedBy: {
+      type: 'number',
+      description: 'Player number of player requesting move',
+      required: true,
+    },
+    priorStates: {
+      type: 'ref',
+      description: 'List of packed gameStateRows for this game\'s prior states',
+      required: true,
+    }
+  },
+  sync: true,
+  fn: ({ requestedMove, currentState, playedBy }, exits) => {
+    try {
+      const activePlayerPNum = currentState.p0.hand.length > 8 ? 0 : 1;
+      if (playedBy !== activePlayerPNum) {
+        throw new BadRequestError('game.snackbar.global.notYourTurn');
+      }
+
+      if (currentState.phase !== GamePhase.DISCARDING_TO_HAND_LIMIT) {
+        throw new BadRequestError('game.snackbar.oneOffs.discardToHandLimit.notDiscardingPhase');
+      }
+
+
+      const player = playedBy ? currentState.p1 : currentState.p0;
+      const overflowCount = player.hand.length - 8;
+
+      if (overflowCount <= 0) {
+        throw new BadRequestError('game.snackbar.oneOffs.discardToHandLimit.handNotOverLimit');
+      }
+
+      const { discardedCards } = requestedMove;
+
+      if (!Array.isArray(discardedCards) || discardedCards.length !== overflowCount) {
+        throw new BadRequestError('game.snackbar.oneOffs.discardToHandLimit.mustSelectCards');
+      }
+
+      const allInHand = discardedCards.every(id => player.hand.some(card => card.id === id));
+      if (!allInHand) {
+        throw new BadRequestError('game.snackbar.oneOffs.discardToHandLimit.mustSelectCards');
+      }
+
+      return exits.success();
+    } catch (err) {
+      return exits.error(err);
+    }
+  },
+};

api/helpers/game-states/moves/draw/execute.js

@@ -36,12 +36,13 @@ module.exports = {
     const player = playedBy ? result.p1 : result.p0;
 
     player.hand.push(result.deck.shift());
-    result.turn++;
+    const playerMustDiscard = player.hand.length > 8;
 
     result = {
       ...result,
       ...requestedMove,
-      phase: GamePhase.MAIN,
+      phase: playerMustDiscard ? GamePhase.DISCARDING_TO_HAND_LIMIT : GamePhase.MAIN,
+      turn: playerMustDiscard ? result.turn : result.turn + 1,
       playedBy,
       playedCard: null,
       targetCard: null,

api/helpers/game-states/moves/draw/validate.js

@@ -47,12 +47,6 @@ module.exports = {
         throw new BadRequestError('game.snackbar.global.notYourTurn');
       }
 
-      // Must be under hand limit of 8
-      const player = playedBy ? currentState.p1 : currentState.p0;
-      if (player.hand.length >= 8) {
-        throw new BadRequestError('game.snackbar.draw.handLimit');
-      }
-
       // Deck must have cards
       if (!currentState.deck.length) {
         throw new BadRequestError('game.snackbar.draw.deckIsEmpty');

api/helpers/game-states/moves/face-card/execute.js

@@ -42,12 +42,13 @@ module.exports = {
 
     player.faceCards.push(playedCard);
 
-    result.turn++;
+    const playerMustDiscard = player.hand.length > 8;
 
     result = {
       ...result,
       ...requestedMove,
-      phase: GamePhase.MAIN,
+      phase: playerMustDiscard ? GamePhase.DISCARDING_TO_HAND_LIMIT : GamePhase.MAIN,
+      turn: playerMustDiscard ? result.turn : result.turn + 1,
       playedBy,
       playedCard,
       targetCard: null,

api/helpers/game-states/moves/jack/execute.js

@@ -57,12 +57,13 @@ module.exports = {
     // Add targetCard to player's points
     player.points.push(targetCard);
 
-    result.turn++;
+    const playerMustDiscard = player.hand.length > 8;
 
     result = {
       ...result,
       ...requestedMove,
-      phase: GamePhase.MAIN,
+      phase: playerMustDiscard ? GamePhase.DISCARDING_TO_HAND_LIMIT : GamePhase.MAIN,
+      turn: playerMustDiscard ? result.turn : result.turn + 1,
       playedBy,
       playedCard,
       targetCard,

api/helpers/game-states/moves/pass/execute.js

@@ -33,12 +33,14 @@ module.exports = {
   fn: ({ currentState, requestedMove, playedBy }, exits) => {
     let result = _.cloneDeep(currentState);
 
-    result.turn++;
+    const player = playedBy ? result.p1 : result.p0;
+    const playerMustDiscard = player.hand.length > 8;
 
     result = {
       ...result,
       ...requestedMove,
-      phase: GamePhase.MAIN,
+      phase: playerMustDiscard ? GamePhase.DISCARDING_TO_HAND_LIMIT : GamePhase.MAIN,
+      turn: playerMustDiscard ? result.turn : result.turn + 1,
       playedBy,
       playedCard: null,
       targetCard: null,

api/helpers/game-states/moves/points/execute.js

@@ -39,12 +39,13 @@ module.exports = {
     const cardIndex = player.hand.findIndex(({ id }) => id === cardId);
 
     player.points.push(...player.hand.splice(cardIndex, 1));
-    result.turn++;
+    const playerMustDiscard = player.hand.length > 8;
 
     result = {
       ...result,
       ...requestedMove,
-      phase: GamePhase.MAIN,
+      phase: playerMustDiscard ? GamePhase.DISCARDING_TO_HAND_LIMIT : GamePhase.MAIN,
+      turn: playerMustDiscard ? result.turn : result.turn + 1,
       playedBy,
       playedCard: player.points.at(-1),
       targetCard: null,

api/helpers/game-states/moves/resolve-five/execute.js

@@ -48,21 +48,19 @@ module.exports = {
     }
 
     const cardsToDraw = Math.min(3, result.deck.length);
-    const spaceInHand = 8 - player.hand.length;
-    const actualCardsToDraw = Math.min(cardsToDraw, spaceInHand);
-
-    player.hand.push(...result.deck.splice(0, actualCardsToDraw));
+    player.hand.push(...result.deck.splice(0, cardsToDraw));
+    const playerMustDiscard = player.hand.length > 8;
 
     result = {
       ...result,
       ...requestedMove,
-      phase: GamePhase.MAIN,
+      phase: playerMustDiscard ? GamePhase.DISCARDING_TO_HAND_LIMIT : GamePhase.MAIN,
+      turn: playerMustDiscard ? result.turn : result.turn + 1,
       playedBy,
       playedCard: null,
       targetCard: null,
       resolved: result.oneOff,
       oneOff: null,
-      turn: result.turn + 1,
     };
 
     return exits.success(result);

api/helpers/game-states/moves/resolve-four/execute.js

@@ -51,12 +51,13 @@ module.exports = {
       result.scrap.push(...player.hand.splice(cardIndex2, 1));
     }
 
-    result.turn++;
+    const playerMustDiscard = player.hand.length > 8;
 
     result = {
       ...result,
       ...requestedMove,
-      phase: GamePhase.MAIN,
+      phase: playerMustDiscard ? GamePhase.DISCARDING_TO_HAND_LIMIT : GamePhase.MAIN,
+      turn: playerMustDiscard ? result.turn : result.turn + 1,
       playedBy,
       playedCard: null,
       targetCard: null,

api/helpers/game-states/moves/resolve-three/execute.js

@@ -43,12 +43,13 @@ module.exports = {
     player.hand.push(targetCard);
     result.scrap.push(result.oneOff);
 
-    result.turn++;
+    const playerMustDiscard = player.hand.length > 8;
 
     result = {
       ...result,
       ...requestedMove,
-      phase: GamePhase.MAIN,
+      phase: playerMustDiscard ? GamePhase.DISCARDING_TO_HAND_LIMIT : GamePhase.MAIN,
+      turn: playerMustDiscard ? result.turn : result.turn + 1,
       playedBy,
       playedCard: null,
       targetCard,