Mitigate fast-jwt whitespace-prefixed key algorithm confusion#82
Merged
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
^anchor and the public key path does not normalize input.Description
patchedDependenciesentry inpnpm-workspace.yamlso installs apply a local patch tofast-jwt@6.1.0.performDetectPublicKeyAlgorithmsinfast-jwtto callkey.trimStart()(stored asnormalizedKey) and usenormalizedKeyfor PEM/X509/private-key detection and matching instead of the rawkey.patches/fast-jwt@6.1.0.patchand updatepnpm-lock.yamlto register the patch hash/path so installs are deterministic and include the mitigation.Testing
pnpm testand all tests passed.pnpm patchworkflow and the lockfile was updated to reference the patched artifact.Codex Task