Skip to content

fix(hud): show axis labels next to metric values in Point Analysis panel - #30

Merged
dmerced05 merged 1 commit into
mainfrom
fix/point-analysis-label-layout
Jul 21, 2026
Merged

fix(hud): show axis labels next to metric values in Point Analysis panel#30
dmerced05 merged 1 commit into
mainfrom
fix/point-analysis-label-layout

Conversation

@makayo

@makayo makayo commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Closes #21

The Point Analysis panel's metric section previously showed a header line ("Metrics (x, y, z)") followed by a 3-column grid of bare values — the axis name only appeared in that header or a hover tooltip, making it easy to misread which value belonged to which axis.

Each metric now gets its own label-left/value-right row, matching the existing UID and Classification row style already used elsewhere in the same panel.

Testing:

  • Lint clean, typecheck clean
  • Verified visually: hovering points across the bundled dataset and a loaded CSV, all three axis labels display correctly next to their values

Screenshot:

  • Point Analysis panel with a point hovered, showing orig_bytes/invel_pps/invel_bpp each labeled directly next to their value
pinpoint

Point Analysis panel previously showed a header line ("Metrics (x, y, z)")
followed by a 3-column grid of bare values — the axis name only
appeared in that header or a hover tooltip, making it easy to misread
which value belonged to which axis.

Each metric now gets its own label-left/value-right row, matching the
existing UID and Classification row style. Rows are generated by
mapping over [x, y, z] rather than three hand-written blocks, with
border logic based on array length rather than a hardcoded index.
@makayo
makayo requested review from Copilot and dmerced05 July 21, 2026 05:19
@makayo makayo self-assigned this Jul 21, 2026
@makayo makayo added the bug Something isn't working label Jul 21, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Point Analysis HUD so axis names are shown directly next to their corresponding metric values, reducing the chance of misreading x/y/z values and keeping labels consistent with the active dataset’s axis mappings.

Changes:

  • Replace the 3-column “bare values” metrics grid with three label-left/value-right rows.
  • Render metric rows by mapping over ["x", "y", "z"] and reading both axisLabels[axis] and hoveredPoint[axis].

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/App.tsx
correct even if this array's size ever changes,
rather than depending on someone remembering to
update a hardcoded index alongside it. */}
<span className="text-white/40 text-[10px] block mb-1">

@dmerced05 dmerced05 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dmerced05
dmerced05 merged commit 0d95e01 into main Jul 21, 2026
1 check passed
@makayo
makayo deleted the fix/point-analysis-label-layout branch July 28, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Point Analysis panel labels to match renamed axes (E/C/W → orig-bytes/invel-pps/invel-bpp)

3 participants