Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch implements persistent storage for Modbus registers and related documentation, tests, and configuration updates. It adds a new persistence library, integrates persistence into the server shutdown flow (graceful save), updates examples and configuration to support persistence, and includes supporting documentation and community files.
Highlights
Key Changes (features & fixes)
Persistence implementation: New library and integration
src/app/lib/register_persistence/__init__.pyimplementing register persistence and storage optimizations.src/app/modbus_server.py).src/app/modbus_server.jsonand examples.Tests
tests/test_register_persistence.pyto exercise the new persistence library.tests/test_server.py,tests/__init__.py).Documentation & Project Files
SECURITY.md,CODE_OF_CONDUCT.md,CONTRIBUTING.md.arc42/architecture.mdand diagram files underarc42/diagrams/.Examples & Configuration
examples/test.json,examples/abb_coretec_example.json, andexamples/udp.json(removed deprecated fields, enabled debug in test examples, and added persistence-related configuration where applicable).Build / CI / Packaging
.github/workflows/test.yamlandDockerfilevariants for version changes and compatibility.Other fixes
.gitignoreto ignore virtual envs and envrc.src/app/__init__.py(file deletion).Files of interest
src/app/lib/register_persistence/__init__.py— new persistence librarysrc/app/modbus_server.py— integrated persistence and graceful-save adjustmentssrc/app/modbus_server.json— new/updated persistence configurationtests/test_register_persistence.py— new testsexamples/test.json— example updated to reflect debug/persistence configSECURITY.md,CODE_OF_CONDUCT.md,CONTRIBUTING.md— new repository-level docsarc42/architecture.mdandarc42/diagrams/— architecture documentation and diagramsTesting & Validation
cd src/ pip install -r requirements.txt pytestMigration / Configuration Notes
modbus_server.json. If upgrading from a branch without persistence, checkpersistencesettings insrc/app/modbus_server.jsonand the example files.Backward compatibility & Caveats