[*] remove redundant Source Name from Tables Overview dashboard, fixes #1134#1160
Conversation
Pull Request Test Coverage Report for Build 21663884968Details
💛 - Coveralls |
|
It's not removed; you just removed the aliasing. You'd also need not to query it in the panels. 
|
|
Just to confirm my understanding : for single-db dashboards, should the dbname column be removed entirely from the panels, relying on the dashboard context instead , right ? |
| "format": "table", | ||
| "rawQuery": true, | ||
| "rawSql": "select\n x.*,\n (data->>'seconds_since_last_vacuum')::int8 as last_vacuum,\n (data->>'seconds_since_last_analyze')::int8 as last_analyze\nfrom (\nSELECT\n dbname,\n tag_data->>'table_full_name' as table_full_name,\n max((data->>'total_relation_size_b')::int8) as total_relation_size,\n max((data->>'table_size_b')::int8) as data_size\nFROM\n table_stats\nWHERE\n $__timeFilter(time)\n AND dbname = '$dbname'\nGROUP BY 1, 2\nORDER BY 3 DESC NULLS LAST\nLIMIT $top\n) x\njoin lateral (select data from table_stats where dbname = x.dbname and tag_data->>'table_full_name' = x.table_full_name and $__timeFilter(time) order by time desc limit 1) y on true", | ||
| "rawSql": "select\n x.*,\n (data->>'seconds_since_last_vacuum')::int8 as last_vacuum,\n (data->>'seconds_since_last_analyze')::int8 as last_analyze\nfrom (\nSELECT\n tag_data->>'table_full_name' as table_full_name,\n max((data->>'total_relation_size_b')::int8) as total_relation_size,\n max((data->>'table_size_b')::int8) as data_size\nFROM\n table_stats\nWHERE\n $__timeFilter(time)\n AND dbname = '$dbname'\nGROUP BY 1 \nORDER BY 3 DESC NULLS LAST\nLIMIT $top\n) x\njoin lateral (select data from table_stats where dbname = '$dbname' and tag_data->>'table_full_name' = x.table_full_name and $__timeFilter(time) order by time desc limit 1) y on true", |
There was a problem hiding this comment.
Why haven't you updated the ORDER BY here?
Please ensure that ORDER BY clauses are updated accordingly in all panels.
|
Plus: resize the panels after removing the also add insepct option to Table name column. |
I changed the default alignment to left for the panel. |
I enabled inspect via a field override on the Table Name column. Should this be done via overrides, or by setting the default inspect option to true? |
It should be an override since we want it for the |
0xgouda
changed the title
Source Name from Tables Overview dashboard, fixes #1134
0xgouda
force-pushed
the
fix/remove-redundant-source-name-issue-1134
branch
from
f165406 to
3ba4de5
Compare
got it , is there any suggested additions, please let me know |
4 participants
Fixes : #1134
This PR removes the redundant dbname / "Source Name" field from dashboards
that only accept a single dbname value to be more clarify.
The change is limited to single-db dashboards (e.g. tables-overview.json).
Global dashboards that may display multiple databases are intentionally left unchanged.
If there are other single-db dashboards should be updated, please let me know.