Skip to content

[*] move cache to Prometheus sink struct, closes #1176#1177

Merged
pashagolub merged 3 commits intocybertec-postgresql:masterfrom
abhijeetsharma200:refactor-prometheus-cache-to-struct
Feb 4, 2026
Merged

[*] move cache to Prometheus sink struct, closes #1176#1177
pashagolub merged 3 commits intocybertec-postgresql:masterfrom
abhijeetsharma200:refactor-prometheus-cache-to-struct

Conversation

@abhijeetsharma200
Copy link
Contributor

Fixes #1176

@coveralls
Copy link

coveralls commented Feb 3, 2026

Pull Request Test Coverage Report for Build 21680298753

Details

  • 22 of 28 (78.57%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+1.0%) to 77.153%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/sinks/prometheus.go 22 28 78.57%
Files with Coverage Reduction New Missed Lines %
internal/sinks/prometheus.go 6 69.27%
Totals Coverage Status
Change from base Build 21674212633: 1.0%
Covered Lines: 4184
Relevant Lines: 5423

💛 - Coveralls

@pashagolub pashagolub self-assigned this Feb 4, 2026
@pashagolub pashagolub added sinks Where and how to store monitored data refactoring Something done as it should've been done from the start labels Feb 4, 2026
@pashagolub pashagolub changed the title Refactor Prometheus writer to have cache in struct instead of global [*] move cache to Prometheus sink struct, closes #1176 Feb 4, 2026
@pashagolub pashagolub force-pushed the refactor-prometheus-cache-to-struct branch from fc5127d to 162935b Compare February 4, 2026 16:50
@pashagolub pashagolub merged commit d583564 into cybertec-postgresql:master Feb 4, 2026
4 checks passed
@abhijeetsharma200 abhijeetsharma200 deleted the refactor-prometheus-cache-to-struct branch February 4, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring Something done as it should've been done from the start sinks Where and how to store monitored data

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PrometheusWriter uses global async metric cache shared across instances

3 participants