Skip to content

test: remove Yarn Modern config comments#1820

Merged
mschile merged 1 commit into
cypress-io:masterfrom
MikeMcC399:remove-yarn-modern-config-comments
Jul 4, 2026
Merged

test: remove Yarn Modern config comments#1820
mschile merged 1 commit into
cypress-io:masterfrom
MikeMcC399:remove-yarn-modern-config-comments

Conversation

@MikeMcC399

@MikeMcC399 MikeMcC399 commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Situation

Due to a bug yarnpkg/berry#1463 in Yarn Modern, any update to the version of Yarn Modern causes the config file yarnrc.yml of the two Yarn Modern examples to be re-written with comments removed.

Change

Execute:

./scripts/update-cypress-latest-yarn.sh

to allow Yarn Modern to reformat yarnrc.yml


Note

Low Risk
Comment-only edits in example Yarn config; no runtime, security, or dependency behavior changes.

Overview
Removes the inline comment on npmMinimalAgeGate in examples/yarn-modern/.yarnrc.yml and examples/yarn-modern-pnp/.yarnrc.yml, leaving the value as 7d with no behavior change.

This matches how Yarn Modern rewrites .yarnrc.yml when the toolchain is updated (see yarnpkg/berry#1463), so the example configs stay stable after running the Cypress/Yarn update script instead of churning on comment removal.

Reviewed by Cursor Bugbot for commit bc7429d. Bugbot is set up for automated code reviews on this repo. Configure here.

@MikeMcC399 MikeMcC399 added bug Something isn't working tests labels Jul 3, 2026
@cypress-app-bot

Copy link
Copy Markdown
Collaborator

@MikeMcC399 MikeMcC399 self-assigned this Jul 3, 2026
@MikeMcC399
MikeMcC399 marked this pull request as ready for review July 3, 2026 08:01
@MikeMcC399
MikeMcC399 requested a review from mschile July 3, 2026 08:01
@mschile
mschile merged commit 15caff4 into cypress-io:master Jul 4, 2026
97 checks passed
@MikeMcC399
MikeMcC399 deleted the remove-yarn-modern-config-comments branch July 4, 2026 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants