Lock in PR-against-fork rule after the upstream-mistarget incident#3
Open
cyrilsayada wants to merge 1 commit into
Open
Lock in PR-against-fork rule after the upstream-mistarget incident#3cyrilsayada wants to merge 1 commit into
cyrilsayada wants to merge 1 commit into
Conversation
A PR got opened against beck-source/inventory-management (upstream parent) instead of cyrilsayada/inventory-management (the fork) because `/pull/new/<branch>` on a fork defaults base to the parent. User caught it, closed the PR (beck-source#99 on beck-source), and had to remediate. CLAUDE.md rule 5.5 ("Open the PR"): - Made it explicit that base = the fork, never upstream - Switched the browser-fallback URL from `/pull/new/<branch>` to `/compare/main...<branch>?expand=1` (compare locks base in URL) - Added a final sanity-check step: visually verify the "base ← compare" selector before telling the user to click Merge LEARNINGS.md: - New entry documenting symptom, root cause (GitHub's intentional fork-default), fix, and the rule Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A PR got opened against beck-source/inventory-management (upstream parent) instead of cyrilsayada/inventory-management (the fork) because
/pull/new/<branch>on a fork defaults base to the parent. User caught it, closed the PR (beck-source#99 on beck-source), and had to remediate.CLAUDE.md rule 5.5 ("Open the PR"):
/pull/new/<branch>to/compare/main...<branch>?expand=1(compare locks base in URL)LEARNINGS.md: