fix: start from current STH/checkpoint when no saved index exists#92
Open
gnana997 wants to merge 1 commit intod-Rickyy-b:static-ctfrom
Open
fix: start from current STH/checkpoint when no saved index exists#92gnana997 wants to merge 1 commit intod-Rickyy-b:static-ctfrom
gnana997 wants to merge 1 commit intod-Rickyy-b:static-ctfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When recovery is enabled but no saved index exists (first run or new log), the worker would start from index 0 and attempt to download billions of historical certificates.
In
runTiledWorker, the conditionw.ctIndex >= 0is always true for uint64, so it never fetched the current checkpoint.In
runStandardWorker, if recovery was enabled, it used whatever ctIndex was set (including 0) without checking if it was a valid saved value.Solution
Check
w.ctIndex > 0to determine if a valid saved index exists. If no saved index exists, fetch the current STH/checkpoint and start from there.