Add machine-specific variable patterns and prefix to CGI API #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CGI server returned hardcoded
#variable patterns for all machines, preventing frontend from accepting Siemens R-parameters likeR5 = 5.Changes
get_machine_regex_patterns()from domain module instead of hardcoded patternsprefixfield to API response - Frontend can now strip the correct prefix (Rfor Siemens,#for Fanuc) from user inputSIEMENS_840DandFANUC_STARinstead of genericMILL/TURNAPI Response
Before:
{ "variables": { "pattern": "#([1-9]|[1-9][0-9]{1,2})(?!\\d)", "description": "Variables #1 - #999" } }After (SIEMENS_840D):
{ "variables": { "pattern": "R(\\d+)", "description": "Variables R1 - R999", "prefix": "R" } }Note
Mobile view alignment, error tab reset, and Ace editor copy issues are frontend concerns not addressed here.
Original prompt
Created from VS Code via the GitHub Pull Request extension.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.