Skip to content

Add table mapping exact Gaussian tests to approximate CLT-based MLE tests#365

Merged
d-morrison merged 7 commits intomainfrom
copilot/add-table-mapping-gaussian-tests
Apr 9, 2026
Merged

Add table mapping exact Gaussian tests to approximate CLT-based MLE tests#365
d-morrison merged 7 commits intomainfrom
copilot/add-table-mapping-gaussian-tests

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 1, 2026

  • Create _tbl_gaussian_vs_mle_tests.qmd with a table mapping exact Gaussian-assumption tests to their approximate CLT-based MLE equivalents
  • Replace "(to add)" placeholder in intro-MLEs.qmd with an include of the new table file
  • Add "CLT" and "siid" to inst/WORDLIST to pass spell check
  • Fix lint CI: add libharfbuzz-dev and libfribidi-dev to system dependencies in lint-changed-files.yaml (required by the textshaping R package)
  • Move supplementary text (assumptions note) out of table caption and into a ::: notes div

Copilot AI changed the title [WIP] Add table mapping Gaussian-assumption tests to CLT-based tests Add table mapping exact Gaussian tests to approximate CLT-based MLE tests Apr 1, 2026
Copilot AI requested a review from d-morrison April 1, 2026 23:15
@d-morrison d-morrison marked this pull request as ready for review April 1, 2026 23:40
Copilot AI review requested due to automatic review settings April 1, 2026 23:40
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fills the placeholder in the MLE chapter with an included reference table that maps exact Gaussian-assumption hypothesis tests to their CLT-based asymptotic MLE counterparts, and updates spellcheck configuration accordingly.

Changes:

  • Added a new cross-referenceable table include for Gaussian vs. asymptotic MLE tests.
  • Replaced the (to add) placeholder in the MLE notes with an include of the new table.
  • Updated the spellcheck wordlist to avoid false positives for newly introduced terminology/macros.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
intro-MLEs.qmd Replaces the placeholder with an include of the new Gaussian-vs-MLE testing table.
_tbl_gaussian_vs_mle_tests.qmd New include defining @tbl-gaussian-vs-mle-tests summarizing exact vs. asymptotic tests/statistics.
inst/WORDLIST Adds CLT and siid to prevent new spellcheck false positives.

Comment thread inst/WORDLIST
@d-morrison
Copy link
Copy Markdown
Owner

…extshaping

Agent-Logs-Url: https://github.com/d-morrison/rme/sessions/d641c154-7896-46ae-a5db-19a12d71f414

Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 2, 2026

@copilot fix https://github.com/d-morrison/rme/actions/runs/23875442958/job/69738117057?pr=365

Fixed in 0ebcbc9. The textshaping package was failing to install because libharfbuzz-dev and libfribidi-dev were missing from the system dependencies step in lint-changed-files.yaml. Added both packages to the apt-get install command.

Comment thread inst/WORDLIST
Comment thread _tbl_gaussian_vs_mle_tests.qmd
Copilot AI requested a review from d-morrison April 7, 2026 17:52
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

PR Preview Action v1.8.1
🚀 Preview available at: https://d-morrison.github.io/rme/pr-preview/pr-365/

Built to branch gh-pages at 2026-04-09 18:16 UTC.

@d-morrison d-morrison merged commit dcb8eb5 into main Apr 9, 2026
3 checks passed
@d-morrison d-morrison deleted the copilot/add-table-mapping-gaussian-tests branch April 9, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add a table mapping exact Gaussian-assumption tests with their corresponding approximate CLT-based tests for MLEs

3 participants