ci: externalize license allow-list to license-whitelist-python.txt#173
Merged
Conversation
Move the inline pip-licenses --allow-only list out of the workflow into license-whitelist-python.txt (one license per line, # comments ignored). The workflow now builds the allow-list from that file, matching the Node submodules' license-whitelist-node.txt convention. Behaviour is unchanged: same entries, still --with-system --partial-match. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Remove the "GNU General Public License (GPL)" entry so strong-copyleft GPL (and AGPL) dependencies fail the license check. LGPL stays allowed: used as a library it imposes no source-disclosure obligation on the application. Verified: current tree (LGPL psycopg) still passes; GPL/AGPL packages are rejected under pip-licenses --partial-match. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Move the inline
pip-licenses --allow-onlylist out of.github/workflows/license-check.ymlinto a dedicatedlicense-whitelist-python.txt(one license per line;#comments and blank lines ignored). The workflow now builds the allow-list from that file.Why
license-whitelist-node.txtconvention added to thefrontendandchrome-extensionsubmodules, so all three repos manage licenses the same way.Notes
--with-system --partial-match.uv run pip-licenses --with-system --partial-match --allow-only="$(...txt...)"exits 0.🤖 Generated with Claude Code