-
Notifications
You must be signed in to change notification settings - Fork 0
fix: close ghost rooms/users on startup and repair cron env #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| """Close any rooms / users that are still marked alive at startup. | ||
|
|
||
| Channels の WebSocket セッションはプロセス内 (`AnimePartyConsumer`) にのみ存在 | ||
| するため、Django プロセス(コンテナ)が落ちると ``disconnect`` が呼ばれず | ||
| ``AnimeRoom`` / ``AnimeUser`` が ``alive`` のまま残る。次回コンテナ起動時に | ||
| これらを論理削除しておかないと、統計 API(``alive`` 件数)に幽霊セッションが | ||
| 残り続けてしまう。 | ||
|
|
||
| 冪等な操作なので、起動毎に無条件で実行してよい。 | ||
| """ | ||
|
|
||
| from django.core.management.base import BaseCommand | ||
|
|
||
| from streamer.models import AnimeRoom, AnimeUser | ||
|
|
||
|
|
||
| class Command(BaseCommand): | ||
| help = "Logically delete all AnimeRoom / AnimeUser rows still marked alive." | ||
|
|
||
| def handle(self, *args, **options): | ||
| users = AnimeUser.objects.alive().count() | ||
| rooms = AnimeRoom.objects.alive().count() | ||
| AnimeUser.objects.alive().delete() | ||
| AnimeRoom.objects.alive().delete() | ||
| self.stdout.write( | ||
| self.style.SUCCESS( | ||
| f"closed {users} alive user(s) and {rooms} alive room(s)" | ||
| ) | ||
| ) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [mypy] reported by reviewdog 🐶
Cannot find implementation or library stub for module named "django.core.management.base" [import-not-found]