fix(release): skip bump commit when version unchanged and force-update tag#177
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
releaseワークフローのBump version and commitステップが、対象ファイルに version の差分が無いときgit commitの失敗で run 全体を落とす問題を修正します。git commit/git pushを「ステージに差分があれば実行、無ければスキップして次のステップに進む」に変更git tag -f+git push --forceで HEAD に強制再付与 するステップを追加(ルートと各サブモジュールでタグずれが起きた場合の自己修復用)Why
直近の root
releaserun でこの問題が連鎖し、サブモジュール側で bump が完了しているのに root 側ではタグが進まず、再実行しても全サブモジュールがnothing to commitで落ち続ける状態になっていました。本変更で v2.6.1 のような重複実行や、root とサブモジュールの version ズレ復旧時にも release ワークフローが冪等に成功するようにします。How tested
YAML 編集のみ。実走は次回の release ワークフロー起動で確認します。