[WIP] [WIP] Address feedback from PR #77 for release v0.2.1 updates#78
Merged
d0dg3r merged 2 commits intorelease/v0.2.1from Mar 24, 2026
Merged
[WIP] [WIP] Address feedback from PR #77 for release v0.2.1 updates#78d0dg3r merged 2 commits intorelease/v0.2.1from
d0dg3r merged 2 commits intorelease/v0.2.1from
Conversation
…ication behavior Co-authored-by: d0dg3r <5613114+d0dg3r@users.noreply.github.com> Agent-Logs-Url: https://github.com/d0dg3r/NoSuckShell/sessions/8ee46d25-c82d-4b0c-a154-0831e5e47a33
Copilot stopped work on behalf of
d0dg3r due to an error
March 24, 2026 23:06
d0dg3r
added a commit
that referenced
this pull request
Mar 24, 2026
* release: prepare v0.2.1 and align docs - Bump desktop version to 0.2.1 (package.json, lockfile, Cargo.toml, tauri.conf) - CHANGELOG: stable 0.2.1 entry; backfill 0.1.0-beta.12–beta.17 history - Docs: README, releases, architecture, roadmap, licensing, terms, license-server runbook, PROXMUX spec - nosuckshell_ops: mandatory release checklist; validate_project.sh cds to repo root - PROXMUX: TLS/trusted PEM, WS proxy, UI and Help; remove built-in demo plugin - Plugin store: catalog and assets (cloud provider SVGs); related TS/Rust wiring - Ignore .cursor/debug-*.log * Update apps/desktop/src-tauri/Cargo.toml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update apps/desktop/src-tauri/src/plugins/proxmux.rs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update .agents/skills/nosuckshell_ops/scripts/validate_project.sh Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update apps/desktop/src-tauri/src/plugins/proxmux.rs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * [WIP] [WIP] Address feedback from PR #77 for release v0.2.1 updates (#78) * Initial plan * Fix misleading tlsTrustedCertPem comment to reflect actual skip-verification behavior Co-authored-by: d0dg3r <5613114+d0dg3r@users.noreply.github.com> Agent-Logs-Url: https://github.com/d0dg3r/NoSuckShell/sessions/8ee46d25-c82d-4b0c-a154-0831e5e47a33 --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: d0dg3r <5613114+d0dg3r@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: d0dg3r <5613114+d0dg3r@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates PROXMUX VNC pane prop documentation to accurately describe the security behavior of tlsTrustedCertPem in the local WS/TLS bridge flow, aligning the frontend comment with the backend’s actual TLS verification posture.
Changes:
- Corrected the inline doc comment for
tlsTrustedCertPemto state that a non-empty PEM results in skipping TLS verification (equivalent toallowInsecureTls), and that the PEM is not used as a trust anchor.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the feedback on #77. I've created this new PR, which merges into #77, to address your comment. I will work on the changes and keep this PR's description up to date as I make progress.
Original PR: #77
Triggering review: #77 (comment)
📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.