✨ Create or append descriptors to global IDs#9
Merged
Conversation
znatty22
force-pushed
the
upsert-global-ids
branch
from
82d713d to
cee9287
Compare
znatty22
force-pushed
the
upsert-global-ids
branch
from
933c189 to
f949c13
Compare
znatty22
force-pushed
the
upsert-global-ids
branch
from
f949c13 to
829fb48
Compare
znatty22
force-pushed
the
upsert-global-ids
branch
from
b0a8476 to
0b498f6
Compare
haynescd
approved these changes
Feb 14, 2025
Comment on lines
+68
to
+71
| if study_global_id: | ||
| s_id = study_global_id | ||
| else: | ||
| s_id = dewrangle_study_id |
Collaborator
There was a problem hiding this comment.
don't have to change but I prefer this when they are so simple
s_id = study_global_id if (study_global_id) else dewrangle_study_id
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6
To do