Conversation
Owner
Author
|
Looks to be about 65% slower Shallow React Component Test Run Average over 10 runs:
Update: it really looks like only half the time went to object creation... Where the rest go? |
Owner
Author
|
Dist is broken by the flatmap polyfill:
|
Owner
Author
|
flatMap is an unnecessary dependency. I inlined a lot of functional stuff and invoked the dark art of imperative programming. |
7ac75e8 to
881472f
Compare
Owner
Author
|
going up as 1.0.0-next.5 |
add simple mapFlat for recursion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This exposes functions for creating elements and wrapping CSS modules by iterating through them as an alternative to #5. closes #2.
Under the hood, it made sense to enforce an AST, since different systems might provide different semantic meaning by default.
This makes it very modular and clean - the internal syntax machinery resolves and then the configured
transformFnis run for each node.because its doing more traversal and collecting over string building, this might be a lot slower...